Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): Skip this parameters in setter #8158

Merged
merged 5 commits into from
Oct 20, 2023
Merged

fix(es/parser): Skip this parameters in setter #8158

merged 5 commits into from
Oct 20, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 20, 2023

Description:

This is not a proper fix, but let's wait for the conf.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Oct 20, 2023
@kdy1 kdy1 self-assigned this Oct 20, 2023
@kdy1 kdy1 marked this pull request as ready for review October 20, 2023 12:32
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 20, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) October 20, 2023 12:32
kdy1
kdy1 commented Oct 20, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser

swc-bot
swc-bot reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 826386f into swc-project:main Oct 20, 2023
141 of 143 checks passed
@kdy1 kdy1 deleted the issue-8156 branch October 20, 2023 13:30
@kdy1 kdy1 modified the milestones: Planned, v1.3.94 Oct 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.94
Development

Successfully merging this pull request may close these issues.

[es/typescript] swc should drop this
2 participants
@kdy1 @swc-bot