refactor(es/minifier): Simplify analyzer context #8164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR eagerly mark idents as assigned, this may add some performance cost, but generally speaking LHS is very small. |
Austaras
force-pushed
the
main
branch
2 times, most recently
from
e66929c
to
28274a1
Compare
kdy1
reviewed
Oct 23, 2023
| @@ -37,19 +37,19 @@ | |||
| }// same as above but on left of a binary expression | |||
| { | |||
| let b, a = 0; | |||
| [{ 1: b } = [ | |||
| [{ [a = 1]: b } = [ | |||
There was a problem hiding this comment.
Yeah. This PR arises from the problem that assign happens after the evaluation of LHS and RHS, so it's impossible to report reference and assign at the same time.
kdy1
reviewed
Oct 24, 2023
jridgewell
approved these changes
Oct 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BREAKING CHANGE:
Related issue (if exists):