-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(es/minifier): Simplify analyzer context #8164
Conversation
This PR eagerly mark idents as assigned, this may add some performance cost, but generally speaking LHS is very small. |
e66929c
to
28274a1
Compare
@@ -37,19 +37,19 @@ | |||
}// same as above but on left of a binary expression | |||
{ | |||
let b, a = 0; | |||
[{ 1: b } = [ | |||
[{ [a = 1]: b } = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is a bugfix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. This PR arises from the problem that assign happens after the evaluation of LHS and RHS, so it's impossible to report reference and assign at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_ecma_minifier
Description:
BREAKING CHANGE:
Related issue (if exists):