Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Always consider reassigned when inlining #8168

Merged
merged 2 commits into from
Oct 23, 2023
Merged

fix(es/minifier): Always consider reassigned when inlining #8168

merged 2 commits into from
Oct 23, 2023

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Oct 22, 2023 •
edited by kdy1

@Austaras
Copy link
Member Author

I believe this is better than #8166 because this is more consistent -- we don't mark var decl as ref, we shouldn't mark param decl as ref either. But there's no objectively better or worse.

kdy1
kdy1 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that it's still marked as reaasigned. 🤣

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 mentioned this pull request Oct 23, 2023
Closed
@kdy1 kdy1 requested a review from jridgewell October 23, 2023 02:43
@kdy1 kdy1 added this to the Planned milestone Oct 23, 2023
@kdy1 kdy1 changed the title fix(es/minifier): Always consider reassigned when multi inline fix(es/minifier): Always consider reassigned when inlining Oct 23, 2023
@kdy1 kdy1 enabled auto-merge (squash) October 23, 2023 17:15
swc-bot
swc-bot reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit c26a225 into swc-project:main Oct 23, 2023
142 of 144 checks passed
@Austaras Austaras deleted the param branch October 23, 2023 21:44
@kdy1 kdy1 modified the milestones: Planned, v1.3.95 Oct 24, 2023
@dgonzalezr dgonzalezr mentioned this pull request Oct 26, 2023
Merged
1 task
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@jridgewell jridgewell jridgewell approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.95
Development

Successfully merging this pull request may close these issues.

Function param override gets incorrectly inlined
4 participants
@Austaras @jridgewell @kdy1 @swc-bot