feat(es/minifier): Respect inline level and preserve native names #8205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
commented
Nov 1, 2023
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
kdy1
changed the title
kdy1
changed the title
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 7, 2023
### What? * vercel/turbo#6286 * vercel/turbo#6367 * vercel/turbo#6354 * vercel/turbo#6343 --- - Update `swc_core` to `v0.86.40` - Revert #56281 and fix `node-fetch` by disabling inlining - Use `inline: 2` instead of `keep_fnames: true` ### Why? `keep_fnames` increases the bundle size too much. ### How? - Fixes #56612 - Fixes #57886 - Fixes #55682 (by swc-project/swc#8205) - Reverts #56281 - Closes PACK-1902
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Note: Preserving native names is a hack, but it's used by
terserand it's the only way to preserve the name ofclass AbortSignalwhile mangling withoutkeep_classnames: true. We can special caseAbortSignal, but let's just followterser.Related issue:
swc_coretov0.86.40and update turbopack vercel/next.js#57904