Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stable rust #8316

Closed
xobs opened this issue Nov 20, 2023 · 2 comments
Closed

Support stable rust #8316

xobs opened this issue Nov 20, 2023 · 2 comments
Milestone

Comments

@xobs
Copy link

xobs commented Nov 20, 2023

Describe the feature

There are a few places where #[feature(box_patterns)] is used, mostly in css but also in one HTML crate:

Additionally, there is a #![feature(type_name_of_val)] and #![feature(never_type)] in swc_estree_compat.

Babel plugin or link to the feature description

No response

Additional context

#![feature(...)] enables nightly features, and means that such crates cannot work on stable Rust. It also means the code is susceptible to rot as the feature is adjusted, reworked, removed, or even stabilized. Removing the nightly requirement allows code to stay functional for a longer amount of time.

@kdy1 kdy1 added this to the Planned milestone Nov 20, 2023
kdy1 pushed a commit that referenced this issue Dec 4, 2023
kdy1 pushed a commit that referenced this issue Dec 4, 2023
kdy1 pushed a commit that referenced this issue Dec 4, 2023
kdy1 pushed a commit that referenced this issue Dec 4, 2023
kdy1 pushed a commit that referenced this issue Dec 7, 2023
kdy1 pushed a commit that referenced this issue Dec 7, 2023
kdy1 pushed a commit that referenced this issue Dec 7, 2023
kdy1 pushed a commit that referenced this issue Dec 7, 2023
@kdy1
Copy link
Member

kdy1 commented Feb 13, 2024

Closing as done. Thank you, @magic-akari

@kdy1 kdy1 closed this as completed Feb 13, 2024
@kdy1 kdy1 modified the milestones: Planned, v1.4.2 Feb 19, 2024
@swc-bot
Copy link
Collaborator

swc-bot commented Mar 20, 2024

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants