Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/decorators): Resolve enum for design:returntype #8320

Merged
merged 7 commits into from
Nov 22, 2023
Merged

fix(es/decorators): Resolve enum for design:returntype #8320

merged 7 commits into from
Nov 22, 2023
+173 −41

Conversation

ZakisM
Copy link
Contributor

@ZakisM ZakisM commented Nov 20, 2023

Description:

Resolve enum types in design:returntype.

@ZakisM ZakisM requested a review from a team as a code owner November 20, 2023 21:17
@kdy1 kdy1 requested review from magic-akari and kdy1 November 21, 2023 04:11
@kdy1
Copy link
Member

kdy1 commented Nov 21, 2023

cc @magic-akari What's your thought about this? We cannot support enums in other files due to some fundamental reasons.

@magic-akari
Copy link
Member

magic-akari commented Nov 21, 2023 •
edited
Loading

cc @magic-akari What's your thought about this? We cannot support enums in other files due to some fundamental reasons.

I have no idea. I suppose that tsc will emit error for this case with isolatedModules: true.

@ZakisM
Copy link
Contributor Author

ZakisM commented Nov 21, 2023

I don't think isolatedModules: true will highlight this as an issue. This change was meant to match the behaviour that we are currently doing for design:type where if the enum is declared in the same file then the type is resolved correctly. For enums imported from other files we will need to re-look at #1584.

kdy1
kdy1 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_transforms_proposal

@kdy1 kdy1 changed the title fix(ecma/proposal): Resolve enum design:returntype fix(es/decorators): Resolve enum design:returntype Nov 22, 2023
@kdy1 kdy1 changed the title fix(es/decorators): Resolve enum design:returntype fix(es/decorators): Resolve enum in design:returntype Nov 22, 2023
@kdy1 kdy1 changed the title fix(es/decorators): Resolve enum in design:returntype fix(es/decorators): Resolve enum for design:returntype Nov 22, 2023
@kdy1 kdy1 enabled auto-merge (squash) November 22, 2023 05:38
swc-bot
swc-bot reviewed Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment •
edited by kdy1
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 added this to the Planned milestone Nov 22, 2023
@kdy1 kdy1 merged commit 91ef7c9 into swc-project:main Nov 22, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.100 Nov 30, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot

@kdy1 kdy1

@magic-akari magic-akari

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.100
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ZakisM @kdy1 @magic-akari @swc-bot