Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): Update vergen to v8 #8325

Merged
merged 4 commits into from
Nov 23, 2023
Merged

build(deps): Update vergen to v8 #8325

merged 4 commits into from
Nov 23, 2023

Conversation

Redfire75369
Copy link
Contributor

Description:
Updates vergen build dependency in swc_core to v8. This reduces the amount of dependency duplication. In my case in particular, it allows me to remove syn v1 from my repository.

BREAKING CHANGE: None

Related issue (if exists): None

@Redfire75369 Redfire75369 requested a review from a team as a code owner November 21, 2023 11:33
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

kdy1
kdy1 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_core

@kdy1 kdy1 enabled auto-merge (squash) November 22, 2023 06:03
@kdy1 kdy1 added this to the Planned milestone Nov 22, 2023
@kdy1 kdy1 changed the title build(deps): Updated vergen to v8 build(cargo): Update vergen to v8 Nov 23, 2023
@kdy1 kdy1 disabled auto-merge November 23, 2023 03:53
@kdy1 kdy1 enabled auto-merge (squash) November 23, 2023 03:54
swc-bot
swc-bot reviewed Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment •
edited by kdy1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 1315615 into swc-project:main Nov 23, 2023
277 checks passed
@Redfire75369 Redfire75369 deleted the deps/vergen branch November 23, 2023 12:22
@kdy1 kdy1 modified the milestones: Planned, v1.3.100 Nov 30, 2023
@Redfire75369 Redfire75369 changed the title build(cargo): Update vergen to v8 build(deps): Update vergen to v8 Dec 2, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.100
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Redfire75369 @CLAassistant @kdy1 @swc-bot