Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/renamer): Allow globalThis to be shadowed #8327

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix(es/renamer): Allow globalThis to be shadowed #8327

merged 2 commits into from
Nov 23, 2023

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Nov 21, 2023 •
edited by kdy1

@Austaras Austaras requested a review from a team as a code owner November 21, 2023 19:01
@kdy1 kdy1 added this to the Planned milestone Nov 22, 2023
kdy1
kdy1 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_transforms_base

@kdy1 kdy1 changed the title fix(es/base): Allow globalThis to be shadowed fix(es/renamer): Allow globalThis to be shadowed Nov 22, 2023
@kdy1 kdy1 enabled auto-merge (squash) November 22, 2023 05:31
@kdy1 kdy1 merged commit 3dd73a3 into swc-project:main Nov 23, 2023
276 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.100 Nov 30, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@magic-akari magic-akari magic-akari approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.100
Development

Successfully merging this pull request may close these issues.

globalThis ident in decl is rewritten
3 participants
@Austaras @magic-akari @kdy1