Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): Wrap with OptChain across TsNonNull #8332

Merged
merged 5 commits into from
Nov 22, 2023
Merged

fix(es/parser): Wrap with OptChain across TsNonNull #8332

merged 5 commits into from
Nov 22, 2023

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari marked this pull request as ready for review November 22, 2023 17:50
@magic-akari magic-akari requested a review from a team as a code owner November 22, 2023 17:50
@kdy1 kdy1 added this to the Planned milestone Nov 22, 2023
kdy1
kdy1 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 enabled auto-merge (squash) November 22, 2023 22:51
swc-bot
swc-bot reviewed Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge November 22, 2023 23:23
@kdy1 kdy1 merged commit 8af6ffb into swc-project:main Nov 22, 2023
276 checks passed
@magic-akari magic-akari mentioned this pull request Nov 29, 2023
Closed
@kdy1 kdy1 modified the milestones: Planned, v1.3.100 Nov 30, 2023
@magic-akari magic-akari deleted the fix/issue-8326 branch December 5, 2023 03:12
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.100
Development

Successfully merging this pull request may close these issues.

Uncorrect result of transpilation "non-null assertion operator" with nullish coalescing
3 participants
@magic-akari @kdy1 @swc-bot