Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/react): jsx with single spread child is static #8339

Merged
merged 3 commits into from
Nov 26, 2023
Merged

Conversation

rhyzx
Copy link
Contributor

@rhyzx rhyzx commented Nov 24, 2023

Description:

Example:

<h1>{...a}</h1>

Before:

_jsx("h1", {
    children: [
        ...a
    ]
})

After:

_jsxs("h1", {
    children: [
        ...a
    ]
})

Following the implementation in Typescript, jsx with a single spread child should also be considered as static jsx.

Live examples:
Typescript
Esbuild
SWC

@rhyzx rhyzx requested a review from a team as a code owner November 24, 2023 11:18
@CLAassistant
Copy link

CLAassistant commented Nov 24, 2023

CLA assistant check
All committers have signed the CLA.

@kdy1
Copy link
Member

kdy1 commented Nov 25, 2023

Can you sign the CLA?

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_react

@kdy1 kdy1 added this to the Planned milestone Nov 25, 2023
@rhyzx
Copy link
Contributor Author

rhyzx commented Nov 25, 2023

Can you sign the CLA?

Done

@kdy1 kdy1 enabled auto-merge (squash) November 25, 2023 23:59
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 58568fa into swc-project:main Nov 26, 2023
278 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.100 Nov 30, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants