Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/parser): Fix conditional compilation #8343

Merged
merged 6 commits into from
Nov 26, 2023

Conversation

arHSM
Copy link
Contributor

@arHSM arHSM commented Nov 25, 2023

Description:

swc_ecma_parser crate has a typescript feature which enables TS parsing, the Syntax::Typescript variant is behind the typescript feature, compiling without this feature fails as Syntax::Typescript is referenced at many places without #[cfg(feature = "typescript")]

Related issue (if exists):

None

@arHSM arHSM requested a review from a team as a code owner November 25, 2023 13:29
@CLAassistant
Copy link

CLAassistant commented Nov 25, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kdy1 kdy1 added this to the Planned milestone Nov 25, 2023
@kdy1 kdy1 self-assigned this Nov 25, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 changed the title fix: add #[cfg(feature = "typescript")] for Syntax::Typescript references in swc_ecma_parser fix(es/parser): Fix conditional compilation Nov 25, 2023
@kdy1 kdy1 enabled auto-merge (squash) November 26, 2023 11:11
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit a423681 into swc-project:main Nov 26, 2023
278 checks passed
@arHSM arHSM deleted the typescript-cfg branch November 26, 2023 14:09
@kdy1 kdy1 modified the milestones: Planned, v1.3.100 Nov 30, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants