Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(atoms): Evaluate .into() in AtomStoreCell eagerly #8363

Merged
merged 1 commit into from Dec 1, 2023

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Dec 1, 2023

@dsherret dsherret requested a review from a team as a code owner December 1, 2023 15:36
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_atoms

@kdy1 kdy1 changed the title chore: evaluate .into() in AtomStoreCell before borrowing chore(atoms): Evaluate .into() in AtomStoreCell eargerly Dec 1, 2023
@kdy1 kdy1 changed the title chore(atoms): Evaluate .into() in AtomStoreCell eargerly chore(atoms): Evaluate .into() in AtomStoreCell eagerly Dec 1, 2023
@kdy1 kdy1 added this to the Planned milestone Dec 1, 2023
@kdy1 kdy1 merged commit 1e8edb4 into swc-project:main Dec 1, 2023
143 checks passed
@dsherret dsherret deleted the chore_evaluate_into_before_borrow branch December 1, 2023 20:08
@kdy1 kdy1 modified the milestones: Planned, v1.3.101 Dec 18, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

AtomStoreCell can create aliasing mutable references
2 participants