Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/fixer): Preserve parenthesis for optional chaining #8399

Merged
merged 8 commits into from Dec 11, 2023
Merged

fix(es/fixer): Preserve parenthesis for optional chaining #8399

merged 8 commits into from Dec 11, 2023

Conversation

magic-akari
Copy link
Member

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Dec 7, 2023
@magic-akari magic-akari changed the title fix(es/minify): Preserve parenthesis for optional chaining fix(es/base): Preserve parenthesis for optional chaining Dec 7, 2023
@magic-akari magic-akari marked this pull request as ready for review December 7, 2023 18:08
@magic-akari magic-akari requested review from a team as code owners December 7, 2023 18:08
@magic-akari magic-akari marked this pull request as draft December 8, 2023 02:26
@magic-akari magic-akari marked this pull request as ready for review December 8, 2023 05:53
@kdy1 kdy1 self-assigned this Dec 9, 2023
@kdy1 kdy1 changed the title fix(es/base): Preserve parenthesis for optional chaining fix(es/fixer): Preserve parenthesis for optional chaining Dec 11, 2023
kdy1
kdy1 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_transforms_base

@kdy1 kdy1 enabled auto-merge (squash) December 11, 2023 02:40
swc-bot
swc-bot reviewed Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit a69f172 into swc-project:main Dec 11, 2023
276 of 277 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.101 Dec 18, 2023
@kdy1 kdy1 mentioned this pull request Dec 22, 2023
Merged
@kdy1
Copy link
Member

kdy1 commented Dec 22, 2023

It seems like this PR introduced a regression for some unknown reason. I'll investigate.
vercel/next.js#59834 (comment)

@kdy1 kdy1 mentioned this pull request Dec 22, 2023
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 21, 2024
@magic-akari magic-akari deleted the fix/issue-8398 branch February 4, 2024 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.101
Development

Successfully merging this pull request may close these issues.

Incorrect minification of (obj?.a).b
4 participants
@magic-akari @kdy1 @swc-bot @Austaras