Skip to content

refactor(css/parser): Remove value normalization #8434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 78 commits into from
Jan 3, 2024
Merged

refactor(css/parser): Remove value normalization #8434

merged 78 commits into from
Jan 3, 2024
+1,189 −1,129

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 19, 2023 •
edited
Loading

Description:

Related issue :

@kdy1 kdy1 changed the title fix(css/compat): Remove value normalization fix(css): Remove value normalization Dec 19, 2023
@kdy1 kdy1 changed the title fix(css): Remove value normalization fix(css/parser): Remove value normalization Dec 20, 2023
@kdy1 kdy1 marked this pull request as ready for review December 20, 2023 11:26
@kdy1 kdy1 requested a review from a team as a code owner December 20, 2023 11:26
@kdy1
Copy link
Member Author

kdy1 commented Dec 20, 2023

@alexander-akait I removed value normalization because transformY() became transformy()

@alexander-akait
Copy link
Contributor

@kdy1 Hm, but it is valid change, what is the problem, also gzip is better when you have only lower characters

@kdy1 kdy1 added this to the Planned milestone Jan 2, 2024
kdy1
kdy1 commented Jan 3, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_ast

@kdy1 kdy1 marked this pull request as ready for review January 3, 2024 19:45
@kdy1 kdy1 enabled auto-merge (squash) January 3, 2024 19:45
@kdy1 kdy1 disabled auto-merge January 3, 2024 19:45
@kdy1 kdy1 added the automerge label Jan 3, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 3, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) January 3, 2024 19:47
@kdy1 kdy1 disabled auto-merge January 3, 2024 19:48
@kdy1 kdy1 enabled auto-merge (squash) January 3, 2024 19:48
swc-bot
swc-bot reviewed Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 85be8a4 into swc-project:main Jan 3, 2024
@kdy1 kdy1 deleted the css-transform branch January 3, 2024 20:40
@kdy1 kdy1 modified the milestones: Planned, v1.3.103 Jan 15, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot

@kodiakhq kodiakhq[bot]

Assignees
No one assigned
Labels
automerge
Milestone
v1.3.103
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @alexander-akait @swc-bot