Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): Correctly parse the keyword #8483

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix(es/parser): Correctly parse the keyword #8483

merged 2 commits into from
Jan 4, 2024
+112 −7

Conversation

magic-akari
Copy link
Member

@magic-akari
fix(es/parser): The non ident part should not affect the keyword eval…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
793a811 
…uation
@magic-akari magic-akari changed the title fix(es/parser): The non ident part should not affect the keyword evaluation fix(es/parser): Correctly parse the keyword Jan 4, 2024
@magic-akari magic-akari marked this pull request as ready for review January 4, 2024 12:16
@magic-akari magic-akari requested a review from a team as a code owner January 4, 2024 12:16
kdy1
kdy1 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 self-assigned this Jan 4, 2024
@kdy1 kdy1 added this to the Planned milestone Jan 4, 2024
@kdy1 kdy1 enabled auto-merge (squash) January 4, 2024 12:26
@kdy1 kdy1 merged commit 740e6f3 into swc-project:main Jan 4, 2024
@magic-akari magic-akari mentioned this pull request Jan 13, 2024
Closed
@kdy1 kdy1 modified the milestones: Planned, v1.3.103 Jan 15, 2024
@magic-akari magic-akari deleted the fix/issue-8482 branch February 4, 2024 02:38
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.103
Development

Successfully merging this pull request may close these issues.

Syntax Error Reported for "let a = ''" When Using '\u00a0' (Non-breaking Space) Between 'let' and 'a'
2 participants
@magic-akari @kdy1