fix(es/parser): Fix detection of use strict directive
#8617
+78
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
kdy1
commented
Feb 7, 2024
magic-akari
reviewed
Feb 7, 2024
vagusX
reviewed
Feb 7, 2024
| return ( | ||
| function (moduleArg = {}) { | ||
| var Module = moduleArg; | ||
| var readyPromiseResolve, readyPromiseReject; Module["ready"] = new Promise((resolve, reject) => { readyPromiseResolve = resolve; readyPromiseReject = reject }); "use strict"; |
There was a problem hiding this comment.
Should add one more statement "use strict" for this test cases? The origin issue mentioned that there were two "use strict" in the same function.
There was a problem hiding this comment.
It does not matter, because it's not at the start anyway
magic-akari
approved these changes
Feb 7, 2024
swc-bot
reviewed
Feb 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Directives should be at the start of the file, and this PR changes the parser to match only at the start of a file.
Related issue:
node-sqlite3-wasm#8616.