Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Do not drop used properties #8703

Merged
merged 7 commits into from
Mar 7, 2024
Merged

fix(es/minifier): Do not drop used properties #8703

merged 7 commits into from
Mar 7, 2024
+178 −0

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 7, 2024

@kdy1
Add a test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
1b2f237
@kdy1 kdy1 added this to the Planned milestone Mar 7, 2024
@kdy1 kdy1 self-assigned this Mar 7, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0cd7c13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1 added 6 commits March 7, 2024 15:20
kdy1
kdy1 commented Mar 7, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 changed the title fix(es/minifier): Fix hoist_props fix(es/minifier): Do not drop used properties Mar 7, 2024
@kdy1 kdy1 marked this pull request as ready for review March 7, 2024 06:35
@kdy1 kdy1 requested a review from a team as a code owner March 7, 2024 06:35
@kdy1 kdy1 enabled auto-merge (squash) March 7, 2024 06:36
@kdy1 kdy1 merged commit 6069217 into swc-project:main Mar 7, 2024
143 checks passed
@kdy1 kdy1 deleted the issue-8692 branch March 7, 2024 07:18
@kdy1 kdy1 modified the milestones: Planned, v1.4.6 Mar 8, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot]

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.4.6
Development

Successfully merging this pull request may close these issues.

Compress hoist_props removes needed property from object
1 participant
@kdy1