fix(es/decorators): Fix capacity overflow with decorators #8818
+175
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dsherret
commented
Apr 5, 2024
| export function test() { | ||
| var _dec, _initClass, _dec1, _dec2, _initProto; | ||
| let _Foo; | ||
| _dec = decorate(), _dec1 = decorate(), _dec2 = decorate(); |
There was a problem hiding this comment.
I added a test for this because I think in my last PR this expression was accidentally above the var decls, which is not a big deal, but not ideal.
kdy1
approved these changes
Apr 8, 2024
kdy1
changed the title
kdy1
changed the title
swc-bot
reviewed
Apr 8, 2024
swc-bot
reviewed
Apr 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Was looking through the code again and noticed this.
Related issue (if exists): No