Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(visit): Improve Map implementation for Box #8819

Merged
merged 6 commits into from Apr 9, 2024
Merged

fix(visit): Improve Map implementation for Box #8819

merged 6 commits into from Apr 9, 2024

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Apr 5, 2024

Description: See #8817

Related issue (if exists): #8817

@dsherret dsherret requested a review from a team as a code owner April 5, 2024 17:43
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2024 •
edited

⚠️ No Changeset found

Latest commit: 0f4f412

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1
kdy1 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_visit
  • swc_core

@kdy1 kdy1 enabled auto-merge (squash) April 7, 2024 02:00
swc-bot
swc-bot reviewed Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 self-assigned this Apr 8, 2024
@kdy1 kdy1 added this to the Planned milestone Apr 8, 2024
swc-bot
swc-bot reviewed Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit dc04657 into swc-project:main Apr 9, 2024
144 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.4.13 Apr 9, 2024
@dsherret dsherret mentioned this pull request Apr 9, 2024
Merged
@dsherret dsherret deleted the fix_unsoundness_swc_visit branch April 9, 2024 14:11
@kdy1 kdy1 mentioned this pull request Apr 11, 2024
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.4.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsherret @kdy1 @swc-bot