-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/resolver): Correctly check strict mode #8851
Conversation
|
@@ -47,15 +47,15 @@ where | |||
let lexer = Lexer::new(syntax, EsVersion::latest(), StringInput::from(&*fm), None); | |||
let mut parser = Parser::new_from(lexer); | |||
|
|||
let module = parser | |||
.parse_module() | |||
let program = parser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated test file changes come from this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_ecma_transforms_base
- swc_core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
CI failed and it does not look like a random failure.
|
Consider the terser output, I believe the new output is desired. "use strict";
function f() {
g();
x = 10;
throw new Error("foo");
var x;
}
f(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
Description:
BREAKING CHANGE:
Related issue (if exists):
Closes #8842