Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@swc/core-darwin-x64 version 1.5.1 didn't release correctly? #8898

Closed
filipsobol opened this issue Apr 27, 2024 · 8 comments · Fixed by #8901
Closed

@swc/core-darwin-x64 version 1.5.1 didn't release correctly? #8898

filipsobol opened this issue Apr 27, 2024 · 8 comments · Fixed by #8901
Labels
Milestone

Comments

@filipsobol
Copy link

filipsobol commented Apr 27, 2024

Describe the bug

I get a warning when installing @swc/core with yarn classic because @swc/core-darwin-x64 doesn't exist in version 1.5.1 (see https://www.npmjs.com/package/@swc/core-darwin-x64).

It looks like @swc/core and all its optionalDependencies except @swc/core-darwin-x64 have been updated to 1.5.1 a few hours ago.

Input code

No response

Config

No response

Playground link (or link to the minimal reproduction)

https://stackblitz.com/edit/node-6bpu5v

SWC Info output

No response

Expected behavior

Running yarn add @swc/core in the terminal window in the StackBlitz playground should work without any warnings or errors.

Actual behavior

No response

Version

1.5.1

Additional context

No response

@RobinTail
Copy link

RobinTail commented Apr 27, 2024

@surya-stratforge

This comment has been minimized.

@dminglv
Copy link

dminglv commented Apr 27, 2024

the same error with 1.5.2 version

upd: problem also occurs on version 1.5.0 even with a clean installation (using yarn and without yarn.lock file)

@Knyazgori

This comment has been minimized.

@stevebrowndotco
Copy link

stevebrowndotco commented Apr 27, 2024

My builds are failing with yarn 4, with no changs to yarn.lock file. I am getting:

Couldn't find any versions for "@swc/core-darwin-x64" that matches "1.5.2"

I don't directly depend on the package so not sure what is happening

@kdy1
Copy link
Member

kdy1 commented Apr 27, 2024

Artifact name is valid!
Container for artifact "bindings-x86_64-apple-darwin" successfully created. Starting upload of file(s)
Uploaded /Users/runner/work/swc/swc/swc (69.5%) bytes 0:8388607
Uploaded /Users/runner/work/swc/swc/swc.darwin-arm64.node (62.6%) bytes 0:8388607
Uploaded /Users/runner/work/swc/swc/swc (100.0%) bytes 8388608:12064104
Uploaded /Users/runner/work/swc/swc/swc.darwin-arm64.node (100.0%) bytes 8388608:13398163
Total size of all the files uploaded is 2546[22](https://github.com/swc-project/swc/actions/runs/8859201714/job/24328713942#step:16:23)69 bytes
File upload process has finished. Finalizing the artifact upload
Artifact has been finalized. All files have been successfully uploaded!

This looks wrong. It's action for mac os with x86_64 target but the binary name is arm64. cc @Brooooooklyn Can you take a look?

@kdy1
Copy link
Member

kdy1 commented Apr 27, 2024

I

  • deprecated v1.5.0, v1.5.1 and v1.5.2
  • tagged v1.4.17 as latest.

I'll keep this issue open until publish action is fixed

@kdy1
Copy link
Member

kdy1 commented Apr 27, 2024

https://github.com/swc-project/swc/actions/runs/8859201714/job/24329123846#step:14:47

2024-04-27T11:12:27.174Z napi:version Update version to 1.5.2 in [/home/runner/work/swc/swc/scripts/npm/darwin-x64]
2024-04-27T11:12:27.245Z napi:version Update version to 1.5.2 in [/home/runner/work/swc/swc/scripts/npm/win32-x64-msvc]
2024-04-27T11:12:27.245Z napi:version Update version to 1.5.2 in [/home/runner/work/swc/swc/scripts/npm/linux-x64-gnu]
2024-04-27T11:12:27.246Z napi:version Update version to 1.5.2 in [/home/runner/work/swc/swc/scripts/npm/linux-x64-musl]
2024-04-27T11:12:27.247Z napi:version Update version to 1.5.2 in [/home/runner/work/swc/swc/scripts/npm/win32-ia32-msvc]
2024-04-27T11:12:27.247Z napi:version Update version to 1.5.2 in [/home/runner/work/swc/swc/scripts/npm/linux-arm-gnueabihf]
2024-04-27T11:12:27.248Z napi:version Update version to 1.5.2 in [/home/runner/work/swc/swc/scripts/npm/linux-arm64-gnu]
2024-04-27T11:12:27.248Z napi:version Update version to 1.5.2 in [/home/runner/work/swc/swc/scripts/npm/darwin-arm64]
2024-04-27T11:12:27.249Z napi:version Update version to 1.5.2 in [/home/runner/work/swc/swc/scripts/npm/linux-arm64-musl]
2024-04-27T11:12:27.250Z napi:version Update version to 1.5.2 in [/home/runner/work/swc/swc/scripts/npm/win32-arm64-msvc]
2024-04-27T11:12:27.257Z napi:pre-publish Github repository: swc-project/swc
 WARNING  %s doesn't exist /home/runner/work/swc/swc/scripts/npm/darwin-x64/swc.darwin-x64.node
npm WARN publish npm auto-corrected some errors in your package.json when publishing.  Please run "npm pkg fix" to address these errors.
npm WARN publish errors corrected:
npm WARN publish Removed invalid "scripts"
npm notice 
npm notice 📦  @swc/core-win32-x64-msvc@1.5.2
npm notice === Tarball Contents === 
npm notice 92B    README.md              
npm notice 804B   package.json           
npm notice 53.4MB swc.win32-x64-msvc.node
npm notice === Tarball Details === 
npm notice name:          @swc/core-win32-x64-msvc                
npm notice version:       1.5.2                                   
npm notice filename:      swc-core-win32-x64-msvc-1.5.2.tgz       
npm notice package size:  16.7 MB                                 
npm notice unpacked size: 53.4 MB                                 
npm notice shasum:        a6547b568949cac9[41](https://github.com/swc-project/swc/actions/runs/8859201714/job/24329123846#step:14:42)ad25ff7eb8d45a6e8717e0
npm notice integrity:     sha512-83TdYh6iugPDn[...]lH0j2rGh1Wx4Q==
npm notice total files:   3                                       
npm notice 
npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
npm notice publish Signed provenance statement with source and build information from GitHub Actions
npm notice publish Provenance statement published to transparency log: https://search.sigstore.dev/?logIndex=89111778
 INFO  Creating GitHub release v1.5.2
 INFO  GitHub release created

@kdy1 kdy1 added this to the Planned milestone Apr 27, 2024
mgansler added a commit to mgansler/plusone that referenced this issue Apr 28, 2024
kdy1 pushed a commit that referenced this issue Apr 29, 2024
`macos-latest` runner was upgraded to `macos-14-arm64`. We need to add `--target x86_64-apple-darwin` explicitly

- Closes #8898
@kdy1 kdy1 modified the milestones: Planned, v1.5.3 Apr 29, 2024
@kdy1 kdy1 modified the milestones: v1.5.3, Planned, v1.5.4 May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

7 participants