Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Consider side effects of operands of binary expressions #8929

Merged
merged 5 commits into from May 7, 2024
Merged

fix(es/minifier): Consider side effects of operands of binary expressions #8929

merged 5 commits into from May 7, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented May 7, 2024

@kdy1 kdy1 added this to the Planned milestone May 7, 2024
@kdy1 kdy1 self-assigned this May 7, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2024 •
edited

⚠️ No Changeset found

Latest commit: 402c6eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review May 7, 2024 04:44
@kdy1 kdy1 requested a review from a team as a code owner May 7, 2024 04:44
kodiakhq[bot]
kodiakhq bot previously approved these changes May 7, 2024
View reviewed changes
kdy1
kdy1 commented May 7, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier
  • swc_core

@kdy1 kdy1 enabled auto-merge (squash) May 7, 2024 04:45
@kdy1 kdy1 changed the title fix(es/minifier): Consider side effects of operands of ** fix(es/minifier): Consider side effects of operands of binary expressions May 7, 2024
@kdy1 kdy1 disabled auto-merge May 7, 2024 04:48
@kdy1 kdy1 enabled auto-merge (squash) May 7, 2024 04:48
swc-bot
swc-bot reviewed May 7, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 4d4a7a9 into swc-project:main May 7, 2024
148 checks passed
@kdy1 kdy1 deleted the issue-8923 branch May 7, 2024 05:27
@kdy1 kdy1 modified the milestones: Planned, v1.5.5 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.5.5
Development

Successfully merging this pull request may close these issues.

minifier: inlining arithmetic assignment expression can result in different output
2 participants
@kdy1 @swc-bot