Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/ast): Pin version of unicodes #8941

Merged
merged 13 commits into from
May 10, 2024
Merged

fix(es/ast): Pin version of unicodes #8941

merged 13 commits into from
May 10, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented May 9, 2024

Description:

#8940 (comment)

I found part of the problem:

U+30FB was added to ID_Continue from Unicode version 14 to 15, but v8 is using an older version of unicode ... which I can't find the exact version.

I spent 2 hours searching for all the missing pieces, I give up.

Let me back port unicode version 14.

Related issue:

@kdy1 kdy1 added this to the Planned milestone May 9, 2024
@kdy1 kdy1 self-assigned this May 9, 2024
@kdy1 kdy1 requested a review from a team as a code owner May 9, 2024 06:59
Copy link

changeset-bot bot commented May 9, 2024

⚠️ No Changeset found

Latest commit: b9561ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 marked this pull request as draft May 9, 2024 06:59
@kdy1 kdy1 changed the title fix(es/codegen): Fix codegen of unicodes fix(es/ast): Fix version of unicodes May 9, 2024
@kdy1 kdy1 changed the title fix(es/ast): Fix version of unicodes fix(es/ast): Pin version of unicodes May 9, 2024
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_ast
  • swc_core
  • swc_ecma_minifier

@kdy1 kdy1 marked this pull request as ready for review May 9, 2024 12:56
@kdy1 kdy1 requested a review from a team as a code owner May 9, 2024 12:56
kodiakhq[bot]
kodiakhq bot previously approved these changes May 9, 2024
@kdy1 kdy1 enabled auto-merge (squash) May 9, 2024 12:57
kodiakhq[bot]
kodiakhq bot previously approved these changes May 10, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes May 10, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes May 10, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes May 10, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes May 10, 2024
@kdy1 kdy1 disabled auto-merge May 10, 2024 02:22
@kdy1 kdy1 merged commit 6362ff4 into swc-project:main May 10, 2024
149 checks passed
@kdy1 kdy1 deleted the issue-8940 branch May 10, 2024 02:23
@kdy1 kdy1 modified the milestones: Planned, v1.5.6 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect compilation of Object Literal with Special Characters
1 participant