Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Avoid reserved name for private method #8949

Merged
merged 1 commit into from
May 13, 2024
Merged

fix(es/compat): Avoid reserved name for private method #8949

merged 1 commit into from
May 13, 2024

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented May 13, 2024 •
edited by kdy1

Description:

Following development should follow babel/babel#16261 to avoid separate WeakMap for each individual private method

Related issue:

@Austaras Austaras requested a review from a team as a code owner May 13, 2024 04:36
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: 4f089c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1
kdy1 approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_compat_es2022
  • swc_ecma_ast
  • swc_core

@kdy1 kdy1 self-assigned this May 13, 2024
@kdy1 kdy1 added this to the Planned milestone May 13, 2024
@kdy1 kdy1 enabled auto-merge (squash) May 13, 2024 04:41
@kdy1 kdy1 merged commit 7053bb1 into swc-project:main May 13, 2024
147 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.5.6 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.5.6
Development

Successfully merging this pull request may close these issues.

privateMethod use keyword cause runtime error when translate to es5
2 participants
@Austaras @kdy1