Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives when used with typescript-eslint 4.9.0 #21

Closed
uturnr opened this issue Dec 2, 2020 · 1 comment
Closed

False positives when used with typescript-eslint 4.9.0 #21

uturnr opened this issue Dec 2, 2020 · 1 comment

Comments

@uturnr
Copy link

uturnr commented Dec 2, 2020

With the following versions in package.json:

    "@typescript-eslint/eslint-plugin": "4.9.0",
    "@typescript-eslint/parser": "4.9.0",

I get a warning that is reminiscent of an issue fixed in typescript-eslint 4.1.0 (typescript-eslint/typescript-eslint#2496)

With this in a .d.ts file:

declare module 'test' {
  interface Test {
    test: 'test'
  }
}

I get the warning: 'Test' is defined but never used. (eslintunused-imports/no-unused-vars-ts)

There were adjustments to no-unused-vars in typescript-eslint 4.9.0 that may have broken something. (typescript-eslint/typescript-eslint#2768)

Locking my typescript-eslint version to 4.5.0 (consistent with this library) resolves the issue, but thought I would note what I've experienced.

@uturnr
Copy link
Author

uturnr commented Dec 2, 2020

Whoops! For some reason I though this library was at fault - I just tested and am getting the same error from typescript-eslint itself (of course!) 🤦

@uturnr uturnr closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant