Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle platform EOL #100

Open
patrickfreed opened this issue Apr 26, 2024 · 2 comments
Open

Handle platform EOL #100

patrickfreed opened this issue Apr 26, 2024 · 2 comments

Comments

@patrickfreed
Copy link
Collaborator

We should decide how we want to handle platforms that no longer receive support from swift.org. The immediately obvious choice is to drop support for them in swiftly as well, but swiftly is still useful on these platforms for installing older releases, so it may not make sense to do that. We may want to instead just stop testing for that platform in CI, and then make sure swiftly prints helpful messages when it encounters a release it can't find a toolchain for. Alternatively, we could keep testing on Ubuntu 18.04 until swiftly declares it does not support it, but just run a subset of the tests.

As an example, Ubuntu 18.04 support was recently dropped by the Swift project, meaning no more nightly releases or regular releases will be published by that platform. As a result, the swiftly tests for it have started failing. https://forums.swift.org/t/dropping-support-for-ubuntu-18-04/69561

@adam-fowler
Copy link
Member

Can we support 18.04 for the versions of Swift that support it? And somehow limit CI to that.

@patrickfreed
Copy link
Collaborator Author

Yeah I think that's probably the best path. Today, what will happen is if you run swiftly install <some version not supported>, it'll just print "<toolchain name> does not exist, exiting", but for older versions it'll succeed. We should probably improve this message to be more helpful on platforms that are no longer supported, but otherwise I think that behavior is fine. I don't think we should bother trying to make swiftly install latest work for unsupported platforms, at least not until we use a swift.org API for swiftly.

As far as limiting CI, that should be pretty easy. We'll just need to verify in a few tests that the platform supports installing the latest releases/snapshots before proceeding. We can just hard code this info I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants