Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better separation of HTTP interface and WebAuthn functions #51

Open
JetForMe opened this issue Mar 15, 2024 · 0 comments
Open

Need better separation of HTTP interface and WebAuthn functions #51

JetForMe opened this issue Mar 15, 2024 · 0 comments

Comments

@JetForMe
Copy link
Member

The core functions

  • WebAuthnManager.beginRegistration()
  • WebAuthnManager.finishRegistration()
  • WebAuthnManager.beginAuthentication()
  • WebAuthnManager.finishAuthentication()

should accept and return have native Swift types, rather than encoded types. For example, finishRegistration() takes a RegistrationCredential, which has a URLEncodedBase64 type for id. RegistrationCredential is also used directly for encoding/decoding in transit from the client.

This makes translating webauthn requests a lot more tedious or forces a very specific exchange between client and server.

The webauthn library probably shouldn't have any Codable classes in its core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant