Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollup 3.x support #5

Closed
tzvetelin-vassilev opened this issue Mar 27, 2023 · 7 comments
Closed

rollup 3.x support #5

tzvetelin-vassilev opened this issue Mar 27, 2023 · 7 comments

Comments

@tzvetelin-vassilev
Copy link

Current version is not compliant with latest rollup

@swiing
Copy link
Owner

swiing commented Mar 28, 2023

Could you elaborate what error you get?

@tzvetelin-vassilev
Copy link
Author

tzvetelin-vassilev commented Mar 29, 2023

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: data-manager@1.0.0
npm ERR! Found: rollup@3.20.2
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^3.19.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@"^2.60.0" from rollup-plugin-import-assertions@0.4.0
npm ERR! node_modules/rollup-plugin-import-assertions
npm ERR! rollup-plugin-import-assertions@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@swiing swiing closed this as completed in a52fa99 Apr 2, 2023
@tzvetelin-vassilev
Copy link
Author

Thanks, when this update will be accessible in npm registry?

@swiing
Copy link
Owner

swiing commented Apr 4, 2023

It is undecided at this stage. Meanwhile you can use the following dependency
"github:swiing/rollup-plugin-import-assertions"

@swiing
Copy link
Owner

swiing commented Apr 26, 2023

It looks like rollup 3.x has introduced some support of import assertions. Although from my very quick scan:

  • it does not seem to handle well type: 'css' (see here)
  • support for type: 'json' is qualified as basic

I'd rather have a deeper look and check if (and in which cases) it would make sense to leverage rollup-v3 native code.

Hence, I re-open this issue.

@swiing swiing reopened this Apr 26, 2023
@swiing
Copy link
Owner

swiing commented May 13, 2023

It looks like rollup 3.x has introduced some support of import assertions.
I'd rather have a deeper look and check if (and in which cases) it would make sense to leverage rollup-v3 native code.

Hence, I re-open this issue.

Addressed by d38f724.
Closing...

@swiing swiing closed this as completed May 13, 2023
@swiing
Copy link
Owner

swiing commented May 13, 2023

Thanks, when this update will be accessible in npm registry?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants