Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 support #533

Open
argalasjr opened this issue Dec 4, 2023 · 9 comments
Open

Angular 17 support #533

argalasjr opened this issue Dec 4, 2023 · 9 comments
Labels

Comments

@argalasjr
Copy link

Describe the bug
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/animations@"10.x || 11.x || 12.x || 13.x || 14.x || 15.x || 16.x" from @swimlane/ngx-graph@8.2.3
npm ERR! node_modules/@swimlane/ngx-graph
npm ERR! @swimlane/ngx-graph@"^8.2.3" from the root project

Expected behavior
Support Angular 17

ngx-graph version
8.2.3

@argalasjr argalasjr added the bug label Dec 4, 2023
@Kr0san89
Copy link
Contributor

Kr0san89 commented Dec 15, 2023

created already a PR #532
in the main time in package.json
"overrides": { "@swimlane/ngx-graph": { "@angular/animations": "~17.0.0", "@angular/cdk": "~17.0.0", "@angular/common": "~17.0.0", "@angular/core": "~17.0.0" } }

@Malwinderkaur
Copy link

@marjan-georgiev could we please get release for this PR [#532]. Currently the library is not working with Angular 17

@bsarkadi
Copy link

Any update on when this can be released?

@RamiKassouf
Copy link

Please update this

@devisw0
Copy link

devisw0 commented Apr 16, 2024

Any update for Angular 17?

@ykoitzsch
Copy link

it seems to be working just fine with Angular 17 (at least from what I have seen so far but of course the warning is quite annoying). So a fix for this would be great.

@amitkachi
Copy link

Any update on this? i see PR is already approved! but not merged

created already a PR #532 in the main time in package.json "overrides": { "@swimlane/ngx-graph": { "@angular/animations": "~17.0.0", "@angular/cdk": "~17.0.0", "@angular/common": "~17.0.0", "@angular/core": "~17.0.0" } }

Any update on this? i see PR is already approved! but not merged

@labeled
Copy link

labeled commented May 8, 2024

Bump, Angular 18 is releasing in a few weeks as well.

@FARINE-KHAN
Copy link

it seems to be working just fine with Angular 17 (at least from what I have seen so far but of course the warning is quite annoying). So a fix for this would be great.

can you explain as m facing same error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants