Hot code reloading not working

[siddjain]

Hello,

We are using 4.5.9 of Swoole. We tried to implement hot reloading using the instructions provided in:
https://www.swoole.co.uk/docs/modules/swoole-server-reload

For testing we created a single file server.php that has following code in it:

$http = new Swoole\HTTP\Server("0.0.0.0", 9501);

$http->on('start', function ($server) {
    echo "Swoole http server is started at http://127.0.0.1:9501\n";
});

$http->on('request', function ($request, $response) {
    $response->header("Content-Type", "text/plain");
    $response->end("Hello World\n");
});

$http->on('WorkerStart', function($serv, $workerId) {
    var_dump(get_included_files());
});

$http->on('BeforeReload', function($serv, $workerId) {
    var_dump(get_included_files());
});

$http->on('AfterReload', function($serv, $workerId) {
    var_dump(get_included_files());
});

$http->start();

pcntl_async_signals(true);

pcntl_signal(SIGUSR1, function ($signo) {
	error_log('caught SIGUSR1...');
	var_dump('caught SIGUSR1...');
    $http->reload();
});

we are able to run the server and verify as follows:

$ curl http://localhost:9501
Hello World!

To get the PID we use ps -aux:

# ps -aux
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root         1  0.0  0.1   3732  2660 ?        Ss   16:58   0:00 /bin/bash ./docker-ent
root         6  0.0  1.2 573684 25460 ?        Sl   16:58   0:00 php server.php
root         7  0.0  0.5 133420 12168 ?        S    16:58   0:00 php server.php
root        20  0.0  0.1   3976  3200 pts/0    Ss   16:59   0:00 /bin/bash
root        47  0.0  0.5 133392 10840 ?        S    17:05   0:00 php server.php
root        49  0.0  0.5 133392 10776 ?        S    17:05   0:00 php server.php
root        50  0.0  0.5 133392 10788 ?        S    17:05   0:00 php server.php
root        52  0.0  0.5 133392 10840 ?        S    17:05   0:00 php server.php
root        53  0.0  0.5 133392 10840 ?        S    17:05   0:00 php server.php
root        54  0.0  0.5 133392 10840 ?        S    17:05   0:00 php server.php
root        55  0.0  0.1   7636  2660 pts/0    R+   17:06   0:00 ps -aux

and then we change the response from Hello World! to something else and send a USR1 signal like this:

# kill -USR1 6

Expected:

hot code reload. server should return new response.

Observed:

[2021-05-01 17:07:58 $7.0]	INFO	Server is reloading all workers now

Fatal error: Uncaught ArgumentCountError: Too few arguments to function {closure}(), 1 passed and exactly 2 expected in /app/server.php:41
Stack trace:
#0 [internal function]: {closure}(Object(Swoole\Http\Server))
#1 /app/server.php(49): Swoole\Server->start()
#2 {main}
  thrown in /app/server.php on line 41

Fatal error: Uncaught ArgumentCountError: Too few arguments to function {closure}(), 1 passed and exactly 2 expected in /app/server.php:45
Stack trace:
#0 [internal function]: {closure}(Object(Swoole\Http\Server))
#1 /app/server.php(49): Swoole\Server->start()
#2 {main}
  thrown in /app/server.php on line 45
array(1) {
  [0]=>
  string(15) "/app/server.php"
}
array(1) {
  [0]=>
  string(15) "/app/server.php"
}
array(1) {
  [0]=>
  string(15) "/app/server.php"
}
array(1) {
  [0]=>
  string(15) "/app/server.php"
}
array(1) {
  [0]=>
  string(15) "/app/server.php"
}
array(1) {
  [0]=>
  string(15) "/app/server.php"
}

and server still returns the old response:

$ curl http://localhost:9501
Hello World!

can anyone help us?

[sy-records]

1. Fatal error: Uncaught ArgumentCountError: Too few arguments to function

- $http->on('BeforeReload', function($serv, $workerId) {
+ $http->on('BeforeReload', function($serv) {
    var_dump(get_included_files());
});

- $http->on('AfterReload', function($serv, $workerId) {
+ $http->on('AfterReload', function($serv) {
    var_dump(get_included_files());
});

2. reload

The reload operation can only reload PHP files that were loaded after the worker process was started.

Use the get_included_files function to list which PHP files were loaded before WorkerStart. PHP files in this list cannot be reloaded, even after a reload operation, and need to be shut down and restarted to take effect.