Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save bytes on preventTabClose #14

Open
milkbump opened this issue Jan 20, 2021 · 1 comment
Open

Save bytes on preventTabClose #14

milkbump opened this issue Jan 20, 2021 · 1 comment

Comments

@milkbump
Copy link

Sorry, I'm not on a device I can make a PR. A bit of bike-shedding to save bytes on preventTabClose.

Something along these lines:

// preventTabClose.js

function handler(e) {
	e.preventDefault();
	return '';
}

export const preventTabClose = (_, enabled) => {
    window[enabled 
				? "addEventListener"
				: "removeEventListener"
		]('beforeunload', handler)
    
	return {
        update: preventTabClose,
        destroy: () => preventTabClose(_, false),
    };
};
@swyxio
Copy link
Owner

swyxio commented Jan 20, 2021

am fine with it. need tests more than i need to save bytes rn haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants