fix(hoist-static): don't hoist regexp

vue-macros · May 23, 2023 · 39c72ff · 39c72ff
1 parent 5806748
commit 39c72ff
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 4 deletions.
diff --git a/.changeset/twenty-rice-fix.md b/.changeset/twenty-rice-fix.md
@@ -0,0 +1,6 @@
+---
+'@vue-macros/hoist-static': minor
+'@vue-macros/common': patch
+---
+
+don't hoist regexp
diff --git a/packages/common/src/ast.ts b/packages/common/src/ast.ts
@@ -73,12 +73,16 @@ export function checkInvalidScopeReference(
 export function isStaticExpression(
   node: Node,
   options: Partial<
-    Record<'object' | 'fn' | 'objectMethod' | 'array' | 'unary', boolean> & {
+    Record<
+      'object' | 'fn' | 'objectMethod' | 'array' | 'unary' | 'regex',
+      boolean
+    > & {
       magicComment?: string
     }
   > = {}
 ): boolean {
-  const { magicComment, fn, object, objectMethod, array, unary } = options
+  const { magicComment, fn, object, objectMethod, array, unary, regex } =
+    options
 
   // magic comment
   if (
@@ -148,7 +152,11 @@ export function isStaticExpression(
     case 'TSNonNullExpression': // 1!
     case 'TSAsExpression': // 1 as number
     case 'TSTypeAssertion': // (<number>2)
+    case 'TSSatisfiesExpression': // 1 satisfies number
       return isStaticExpression(node.expression, options)
+
+    case 'RegExpLiteral':
+      return !!regex
   }
 
   if (isLiteralType(node)) return true

diff --git a/packages/hoist-static/tests/__snapshots__/fixtures.test.ts.snap b/packages/hoist-static/tests/__snapshots__/fixtures.test.ts.snap
@@ -23,6 +23,7 @@ const d = 1 || 2
 const e = !1
 const f = 1 ? 2 : 3
 const g = 1 as number
+const h = <number>2
 </script>
 <script setup lang=\\"ts\\">
 
@@ -32,12 +33,13 @@ const g = 1 as number
 
 
 
-// const h = <number>2
+
 const i = {
   a: 'hello',
 }
 const j = [1, 2, 3]
 const k = Symbol()
+const l = /a/
 </script>
 
 <template>

diff --git a/packages/hoist-static/tests/fixtures/basic.vue b/packages/hoist-static/tests/fixtures/basic.vue
@@ -6,12 +6,13 @@ const d = 1 || 2
 const e = !1
 const f = 1 ? 2 : 3
 const g = 1 as number
-// const h = <number>2
+const h = <number>2
 const i = {
   a: 'hello',
 }
 const j = [1, 2, 3]
 const k = Symbol()
+const l = /a/
 </script>
 
 <template>