Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Generation Unittest: Public and Private keys are assigned the wrong way around #188

Closed
bliepp opened this issue Jan 11, 2022 · 1 comment
Closed

Key Generation Unittest: Public and Private keys are assigned the wrong way around #188

bliepp opened this issue Jan 11, 2022 · 1 comment

Comments

@bliepp
Copy link

bliepp commented Jan 11, 2022 •
edited

Most test cases in the tests.test_key.KeyGenTest test class are like

priv, pub = rsa.key.newkeys(...)

but it should be

pub, priv = rsa.key.newkeys(...)

In most test cases this is not a problem since only some common aspects are tested, but it is still formally wrong and might introduce bugs in some cases.
@myheroyuki myheroyuki mentioned this issue May 25, 2022
Merged
@sybrenstuvel
Copy link
Owner

This was fixed by #201. Thanks for the report!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jul 24, 2022
py-rsa: update to 4.9.
d9487b0 
## Version 4.9 - release 2022-07-20

- Remove debug logging from `rsa/key.py`
  ([#194](sybrenstuvel/python-rsa#194)).
- Remove overlapping slots in `PrivateKey` and `PublicKey`.
  ([#189](sybrenstuvel/python-rsa#189)).
- Do not include CHANGELOG/LICENSE/README.md in wheel
  ([#191](sybrenstuvel/python-rsa#191)).
- Fixed Key Generation Unittest: Public and Private keys are assigned the wrong way around
  ([#188](sybrenstuvel/python-rsa#188)).
mtremer pushed a commit to ipfire/ipfire-2.x that referenced this issue Nov 11, 2022
@pmu-ipf
python3-rsa:Update to version 4.9 and to work with python-3.10.8
4c97d1c 
- Updated from version 4.8 to 4.9
- Update of rootfile
- Changelog
    ## Version 4.9 - release 2022-07-20
	- Remove debug logging from `rsa/key.py`
	  ([#194](sybrenstuvel/python-rsa#194)).
	- Remove overlapping slots in `PrivateKey` and `PublicKey`.
	  ([#189](sybrenstuvel/python-rsa#189)).
	- Do not include CHANGELOG/LICENSE/README.md in wheel
	  ([#191](sybrenstuvel/python-rsa#191)).
	- Fixed Key Generation Unittest: Public and Private keys are assigned the wrong way around
	  ([#188](sybrenstuvel/python-rsa#188)).

Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sybrenstuvel @bliepp