Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transport] Add option cleanup #621

Open
sybrew opened this issue Feb 8, 2023 · 1 comment
Open

[Transport] Add option cleanup #621

sybrew opened this issue Feb 8, 2023 · 1 comment
Assignees
Labels
[Extension Manager] [Extension type] Free [Type] Feature Something new we need to write from the ground up.

Comments

@sybrew
Copy link
Owner

sybrew commented Feb 8, 2023

For Transport, add a checkbox to clean the options of an SEO plugin.

Cleaning the options should also deactivate the SEO plugin (and related plugins, like Pro versions or add-ons).
This is necessary to prevent automatic repopulation of the options and further annoyances, such as the setup wizard.

@sybrew sybrew added [Extension type] Free [Extension Manager] [Type] Feature Something new we need to write from the ground up. labels Feb 8, 2023
@sybrew sybrew self-assigned this Feb 8, 2023
@sybrew
Copy link
Owner Author

sybrew commented May 5, 2023

From Vladimir's comment:

Sybre wrote: TSF cleans up all transported data of Rank Math, so your database is squeaky clean right after transporting.

it’s in vain! It turns out that if a person just wants to see how your plugin works, try it, then you erase the database for him!

This is sabotage!

if a person has not made a backup copy before the transfer, then he will lose part of the site data!

I agree. We should not rewrite or automatically clean up the data but only copy every data point instead.
Then, only delete the old data if the user so chooses via a checkbox.

This might be tricky when the meta keys match -- but this is only an issue with Genesis (from which we copied the keys).

An edge case we might face is when there's no more disk space. However, this is rare and solvable by the user manually -- on failure, the logger should report there's no writable disk space, though I might want to test that and add it to the FAQ (just in case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension Manager] [Extension type] Free [Type] Feature Something new we need to write from the ground up.
Projects
None yet
Development

No branches or pull requests

1 participant