Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom post titles broken since 4.2.8 #625

Open
mjulian87 opened this issue Mar 20, 2023 · 2 comments
Open

Custom post titles broken since 4.2.8 #625

mjulian87 opened this issue Mar 20, 2023 · 2 comments
Labels
[Type] Support It's also a question, but a resolution is required.

Comments

@mjulian87
Copy link

After updating from 4.2.7 to 4.2.8 the title on custom posts is Untitled | Blog Name.

@sybrew
Copy link
Owner

sybrew commented Apr 1, 2023

Hello! Sorry, I missed your issue.

Since TSF v4.2.8, if a post type doesn't support the 'title' feature, it won't get title generation support anymore.
This aligns with WordPress's intent and prevents it from reading unmanageable/unreachable data.

You can still add a custom title. But it'd be best to add title support to the post type.

@sybrew sybrew added the [Type] Support It's also a question, but a resolution is required. label Apr 1, 2023
@mjulian87
Copy link
Author

mjulian87 commented Apr 1, 2023

Hi @sybrew,

Thanks for the information.

My understanding is that the 'supports' array was to determine which features to support on the edit screen, not to determine whether a post type directly supports a feature. From the WordPress Developer Handbook:

All core features are directly associated with a functional area of the edit screen, such as the editor or a meta box.

The custom post type that is causing the issue, doesn't have 'title' in the supports array because the title is generated from other meta that the user enters, and the option to edit the title manually should not be available to the user.

However WordPress is aware that the post has a title, and if I run the_title(), the correct title is returned.

I'm not sure that this is how WordPress intended the supports feature to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Support It's also a question, but a resolution is required.
Projects
None yet
Development

No branches or pull requests

2 participants