Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation recommends deprecated weealloc #614

Closed
vi opened this issue May 24, 2023 · 1 comment · Fixed by #630
Closed

Documentation recommends deprecated weealloc #614

vi opened this issue May 24, 2023 · 1 comment · Fixed by #630
Labels
A-docs Area: documentation

Comments

@vi
Copy link

vi commented May 24, 2023

For minimizing wasm size, Sycamore docs recommend using Weealloc. But this repository is no longer recommended to use and links to it should be phased out.

Other mini-alloc such as lolalloc should be recommended instead.

Precedent: rustwasm/wasm-pack#1258
@lukechu10 lukechu10 added the A-docs Area: documentation label May 24, 2023
@lukechu10
Copy link
Collaborator

I think for now the best would just be to remove the suggestion for replacing the allocator all-together since lol-alloc is a much smaller project than wee-alloc. We can maybe re-introduce this when/if there is a better allocator available.

lukechu10 added a commit that referenced this issue Oct 6, 2023
@lukechu10
Dont suggest wee-alloc in docs
075e3a9 
`wee-alloc` should no longer be recommended because of a memory leak: rustwasm/wee_alloc#85

It appears that the project is abandoned and that this issue will not be fixed anytime soon.

Closes #614
@lukechu10 lukechu10 mentioned this issue Oct 6, 2023
Merged
lukechu10 added a commit that referenced this issue Oct 6, 2023
@lukechu10
Dont suggest wee-alloc in docs (#630)
a1b288b 
`wee-alloc` should no longer be recommended because of a memory leak: rustwasm/wee_alloc#85

It appears that the project is abandoned and that this issue will not be fixed anytime soon.

Closes #614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dont suggest wee-alloc in docs sycamore-rs/sycamore
2 participants
@vi @lukechu10