Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve address validation #1866

Open
cryptoBeliever opened this issue Jun 1, 2022 · 0 comments
Open

Improve address validation #1866

cryptoBeliever opened this issue Jun 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Jun 1, 2022

Current behavior

At this moment wallet is not performing full validation (with checksum check) for address on user input e.g:

  • when putting the address on the transfer transaction form (simple and in aggregate)
  • when adding to the address book
  • when creating an invoice

Example invalid addresses:

  • NCAPJJ712WUYFFTBCPY3CZUEFJYVQUHQ5DH5HAA
  • NCAPJJ712WUYFFTBCPY3CZUEFJYVQUHQ5DH5AAA
  • NCAPJJ712WUYFFTBCPY3CZUEFJYVQUHQ5DHAAAA

What's the issue?

Because of limited validation, there are often problems on the serialization level where the wallet is unable to create transactions.
For example when I'm using an invalid address (TCAPJJ712WUYFFTBCPY3CZUEFJYVQUHQ5DH5HAA) and trying to send tx serialization failing:

image

image

Expected behavior

The wallet should validate provided by the user's address strictly with checksum checks.

@cryptoBeliever cryptoBeliever added the enhancement New feature or request label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant