Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network hardcoded properties from desktop-wallet #1926

Open
cryptoBeliever opened this issue Nov 3, 2022 · 0 comments
Open

Remove network hardcoded properties from desktop-wallet #1926

cryptoBeliever opened this issue Nov 3, 2022 · 0 comments

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Nov 3, 2022

Current behavior:

Currently, we have in NetworkConfig hardcoded values:

  • defaultTestnetNetworkConfig
  • defaultMainnetNetworkConfig

Expected behavior:

All network properties should be fetched from the node. Important is to verify offline transactions which may use those hardcoded values too (since we are unable to fetch in offline mode data from the node). In such a case, we have to rebuild the offline transactions view and potentially ask the user to put/choose generation hash / mosaic id (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant