Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline transactions - invalid deadline calculation #1980

Open
cryptoBeliever opened this issue Apr 15, 2023 · 0 comments
Open

Offline transactions - invalid deadline calculation #1980

cryptoBeliever opened this issue Apr 15, 2023 · 0 comments

Comments

@cryptoBeliever
Copy link
Contributor

What's the issue?

Desktop wallet calculates incorrect deadlines for offline transactions. This causes Failure_Core_Past_Deadline when announcing.

Example signed transaction:

B000000000000000692DE12C9BD80C5F00ECADCED4190C80FE18777F52C3279335B9FEF097F25E79B8933A7E1EE50993FD2646AE9C2E00F06E2A99D7FF3F6370BE135FBB7CF37F061E7D10805F25609A8E3A866F3ED05C5D9B307CD0DE220325B8DD1D6D9108DAB80000000001685441C0440000000000003E5A70550300000068805C51DF7DB65E75F23FA110B3C6A5F14AAB67DB6535050000010000000000F82302A23F91ED6B0000000000000000
(
  signature: 692DE12C9BD80C5F00ECADCED4190C80FE18777F52C3279335B9FEF097F25E79B8933A7E1EE50993FD2646AE9C2E00F06E2A99D7FF3F6370BE135FBB7CF37F06,
  signerPublicKey: 1E7D10805F25609A8E3A866F3ED05C5D9B307CD0DE220325B8DD1D6D9108DAB8,
  version: 0x1,
  network: NetworkType.MAINNET,
  type: TransactionType.TRANSFER,
  fee: 0x00000000000044C0,
  deadline: 0x0000000355705A3E,
  recipientAddress: 68805C51DF7DB65E75F23FA110B3C6A5F14AAB67DB653505,
  mosaics: [
    (
      mosaicId: 0x6BED913FA20223F8,
      amount: 0x0000000000000000,
    )
  ]
  message: hex(),
)

So the calculated deadline is 14318328382, but the current mainnet time is 65708508761.

What's the expected result?

Calculate timestamps/deadlines correctly, considering epoch adjustment.

Affected wallet versions: 1.0.12 and 1.0.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant