Set SysProcAttr Foreground: true when user run cmd. Fixes: #404 #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @sarim |
|
Reverted fornow (with #410 as well) as it doesn't work (at least on Macos where it hangs and ^C doesn't work anymore). |
@fabpot interesting, so "symfony run psql" works for you in macos without setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #404
Details description at linked issue. Setting
SysProcAttrSetpgid: truein a previous commit ff1958f broke interactivty withsymfony run. With things likesymfony run psql.This PR sets Foreground based on runmode. It works in linux. Should work in macos too hopefully.
Not exactly related to this issue/PR, but runner_windows.go is basically dummy. So not sure worker lifecycle/signals/docker integration etc.. works perfectly in windows.