Worker npm_encore_watch watch a file

[ellmout]

Hi,

When working with npx encore dev --watch as a worker, when you change webpack.config.js, you have to restart the worker.

So i config my worker as this :

  npm_encore_watch:
     cmd: ['npx', 'encore', 'dev', '--watch']
     watch: ['webpack.config.js']

To watch for modification of webpack.config.js and restart the worker when i update it.

But it doesn't work !

I have a worker for messenger :

  messenger_consume_async:
     cmd: ['symfony', 'console', 'messenger:consume', 'async']
     watch: ['config', 'src', 'templates', 'vendor']

It works great but only watch dir !

Thx

[sarim]

I guess it's another macos specific issue? It works in my ubuntu.

Off topic: Interesting that webpack itself doesn't reload itself. As webpack is running in watch mode. (I personally use vite, which actually reload on config change).

[tucksaun]

@ellmout work okay for me here.
by any chance: which editor are you using? (some editors updates files content in-place whereas others create new files and then rename them which can cause issues detecting changes)

[ellmout]

hi,
i'm on macOs, using phpstorm !

[tucksaun]

well works for me, I don't really see what could cause your issue 🤷

[tucksaun]

oh except maybe something (just seen that before closing the IDE): you might have autosave enabled and so the reload already happened before you actually hit "Save" ?

[tucksaun]

other hypothesis: maybe your file is not on an actual macOS filesystem (samba share, NFS mount, this kind of things) which might not work with FS change notifications?

[ellmout]

I'm working in my home folder.
I'm making some test this morning

[ellmout]

Juste made some test, i set log level to 4 to see debug info and got :

But i think the cli can't restart npm watch because of #402

[ellmout]

i confirm it's related to #402
when i run npm run watch, i can't kill it with kill -2 or kill -15, it works with kill -9 but it leaves a webpack process running.
i replace npm run watch with

  npm_encore_watch:
    cmd: [ 'node_modules/@symfony/webpack-encore/bin/encore.js', 'dev', '--watch']
    watch: [ 'webpack.config.js' ]

and it's working great !
i will keep it like this for the moment

[yguedidi]

to add one more exemple, I'm using PHPStorm Startup tasks to start the serve command, and now on latest version when I close PHPStorm I get this:

and it waits indefinitely, I have to click "Kill process".
before it closes without manual intervention