Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration test for different configurations #224

Open
ElectricMaxxx opened this issue Apr 1, 2014 · 6 comments
Open

configuration test for different configurations #224

ElectricMaxxx opened this issue Apr 1, 2014 · 6 comments

Comments

@ElectricMaxxx
Copy link
Member

I just fixed just a bug with #223 but i think we should go over the configuration and build different config test cases and test them. Btw we should be able to refactor the one or other Exception in an ->thenInvalid() thing.

@wouterj
Copy link
Member

wouterj commented Jun 27, 2014

There are already quite some config tests: https://github.com/symfony-cmf/RoutingBundle/tree/master/Tests/Resources/Fixtures/config

@dbu
Copy link
Member

dbu commented Jun 27, 2014

if somebody wants to do this, i think the right thing is looking at the code coverage in the Configuration and RoutingBundleExtension classes and you probably mainly notice uncovered sanity checks for invalid configuration. adding tests for those makes sense to avoid regressions.

@wouterj
Copy link
Member

wouterj commented Jun 27, 2014

@dbu looking at the coverage, I think we have covered it quite well: http://jsbin.com/sozimako/1/quiet

@dbu
Copy link
Member

dbu commented Jun 27, 2014

indeed. @ElectricMaxxx what did you find missing?

@wouterj
Copy link
Member

wouterj commented Jun 27, 2014

Hmm, most edge cases of the extension aren't covered: http://jsbin.com/sozimako/2/quiet

@dbu
Copy link
Member

dbu commented Jun 27, 2014

ah yeah. all orm things for example.

most of this validation should ideally be moved into the Configuration
class btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants