Fix parsing docker-composer files with no "version" #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
undefined-array-key-fix
branch
from
30ebebb
to
ed43a3e
Compare
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
undefined-array-key-fix
branch
from
ed43a3e
to
7639e5f
Compare
| @@ -259,7 +259,7 @@ private function configureDockerCompose(Recipe $recipe, array $config, bool $upd | |||
| } | |||
|
|
|||
| // Keep end in memory (check break line on previous line) | |||
| $endAt[$node] = '' !== trim($lines[$i - 1]) ? $i : $i - 1; | |||
| $endAt[$node] = !$i || '' !== trim($lines[$i - 1]) ? $i : $i - 1; | |||
There was a problem hiding this comment.
I change your fix a bit because the previous code was putting a -1 into $endAt[$node].
Can you please confirm this works for you?
There was a problem hiding this comment.
yes, it works
|
Thank you @CountZero1981. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #877