Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/phpunit-bridge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.4.8
Choose a base ref
...
head repository: symfony/phpunit-bridge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.4.10
Choose a head ref
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on Jun 19, 2022

  1. Copy the full SHA
    135172d View commit details

Commits on Jun 20, 2022

  1. [PhpUnitBridge] fix tests

    xabbuh committed Jun 20, 2022
    Copy the full SHA
    1eeae96 View commit details
4 changes: 4 additions & 0 deletions DeprecationErrorHandler/Configuration.php
Original file line number Diff line number Diff line change
@@ -170,6 +170,10 @@ public function tolerates(array $deprecationGroups)
*/
public function isBaselineDeprecation(Deprecation $deprecation)
{
if ($deprecation->isLegacy()) {
return false;
}

if ($deprecation->originatesFromAnObject()) {
$location = $deprecation->originatingClass().'::'.$deprecation->originatingMethod();
} else {
1 change: 1 addition & 0 deletions Tests/DeprecationErrorHandler/baseline.phpt
Original file line number Diff line number Diff line change
@@ -78,3 +78,4 @@ print "Cannot test baselineFile contents because it is generated in a shutdown f
?>
--EXPECT--
Cannot test baselineFile contents because it is generated in a shutdown function registered by another shutdown function.
Legacy deprecation notices (1)
2 changes: 2 additions & 0 deletions Tests/DeprecationErrorHandler/baseline2.phpt
Original file line number Diff line number Diff line change
@@ -66,6 +66,8 @@ $foo->testLegacyFoo();
$foo->testNonLegacyBar();
?>
--EXPECTF--
Legacy deprecation notices (1)

Other deprecation notices (2)

1x: root deprecation
2 changes: 1 addition & 1 deletion Tests/DeprecationErrorHandler/baseline3.phpt
Original file line number Diff line number Diff line change
@@ -69,7 +69,7 @@ $foo->testLegacyFoo();
$foo->testNonLegacyBar();
?>
--EXPECTF--
Legacy deprecation notices (1)
Legacy deprecation notices (2)

Other deprecation notices (2)

1 change: 1 addition & 0 deletions Tests/DeprecationErrorHandler/generate_baseline.phpt
Original file line number Diff line number Diff line change
@@ -62,3 +62,4 @@ print "Cannot test baselineFile contents because it is generated in a shutdown f
?>
--EXPECT--
Cannot test baselineFile contents because it is generated in a shutdown function registered by another shutdown function.
Legacy deprecation notices (1)