Unnecessary Function Call

[justin-oh]

In the documentation for Compiler Passes in Bundles, the example shows:

// src/MyBundle/MyBundle.php
namespace App\MyBundle;

use App\DependencyInjection\Compiler\CustomPass;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Bundle\Bundle;

class MyBundle extends Bundle
{
    public function build(ContainerBuilder $container): void
    {
        parent::build($container);

        $container->addCompilerPass(new CustomPass());
    }
}

However, the call to the parent function is unnecessary because the Bundle class's implementation of the function is empty:

/**
 * This method can be overridden to register compilation passes,
 * other extensions, ...
 *
 * @return void
 */
public function build(ContainerBuilder $container)
{
}

Also, shouldn't anything related to bundles in documentation of 6.1 and beyond be extending AbstractBundle?

[javiereguiluz]

About your first question, we always call the parent method because even if today might be empty, those parent methods could change in the future, so the code must be ready for that.

About the second question: yes, we should use AbstractBundle everywhere. We did some recent changes related to this (see #19793) but we need to update more examples. Thanks!