/
FileValidatorTest.php
437 lines (348 loc) · 14.3 KB
/
FileValidatorTest.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
<?php
/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Symfony\Component\Validator\Tests\Constraints;
use Symfony\Component\HttpFoundation\File\File as FileObject;
use Symfony\Component\HttpFoundation\File\UploadedFile;
use Symfony\Component\Validator\Constraints\File;
use Symfony\Component\Validator\Constraints\FileValidator;
use Symfony\Component\Validator\Test\ConstraintValidatorTestCase;
abstract class FileValidatorTest extends ConstraintValidatorTestCase
{
protected $path;
protected $file;
protected function createValidator()
{
return new FileValidator();
}
protected function setUp(): void
{
parent::setUp();
$this->path = sys_get_temp_dir().\DIRECTORY_SEPARATOR.'FileValidatorTest';
$this->file = fopen($this->path, 'w');
fwrite($this->file, ' ', 1);
}
protected function tearDown(): void
{
parent::tearDown();
if (\is_resource($this->file)) {
fclose($this->file);
}
if (file_exists($this->path)) {
unlink($this->path);
}
$this->path = null;
$this->file = null;
}
public function testNullIsValid()
{
$this->validator->validate(null, new File());
$this->assertNoViolation();
}
public function testEmptyStringIsValid()
{
$this->validator->validate('', new File());
$this->assertNoViolation();
}
public function testExpectsStringCompatibleTypeOrFile()
{
$this->expectException('Symfony\Component\Validator\Exception\UnexpectedValueException');
$this->validator->validate(new \stdClass(), new File());
}
public function testValidFile()
{
$this->validator->validate($this->path, new File());
$this->assertNoViolation();
}
public function testValidUploadedfile()
{
file_put_contents($this->path, '1');
$file = new UploadedFile($this->path, 'originalName', null, null, true);
$this->validator->validate($file, new File());
$this->assertNoViolation();
}
public function provideMaxSizeExceededTests()
{
// We have various interesting limit - size combinations to test.
// Assume a limit of 1000 bytes (1 kB). Then the following table
// lists the violation messages for different file sizes:
// -----------+--------------------------------------------------------
// Size | Violation Message
// -----------+--------------------------------------------------------
// 1000 bytes | No violation
// 1001 bytes | "Size of 1001 bytes exceeded limit of 1000 bytes"
// 1004 bytes | "Size of 1004 bytes exceeded limit of 1000 bytes"
// | NOT: "Size of 1 kB exceeded limit of 1 kB"
// 1005 bytes | "Size of 1.01 kB exceeded limit of 1 kB"
// -----------+--------------------------------------------------------
// As you see, we have two interesting borders:
// 1000/1001 - The border as of which a violation occurs
// 1004/1005 - The border as of which the message can be rounded to kB
// Analogous for kB/MB.
// Prior to Symfony 2.5, violation messages are always displayed in the
// same unit used to specify the limit.
// As of Symfony 2.5, the above logic is implemented.
return [
// limit in bytes
[1001, 1000, '1001', '1000', 'bytes'],
[1004, 1000, '1004', '1000', 'bytes'],
[1005, 1000, '1.01', '1', 'kB'],
[1000001, 1000000, '1000001', '1000000', 'bytes'],
[1004999, 1000000, '1005', '1000', 'kB'],
[1005000, 1000000, '1.01', '1', 'MB'],
// limit in kB
[1001, '1k', '1001', '1000', 'bytes'],
[1004, '1k', '1004', '1000', 'bytes'],
[1005, '1k', '1.01', '1', 'kB'],
[1000001, '1000k', '1000001', '1000000', 'bytes'],
[1004999, '1000k', '1005', '1000', 'kB'],
[1005000, '1000k', '1.01', '1', 'MB'],
// limit in MB
[1000001, '1M', '1000001', '1000000', 'bytes'],
[1004999, '1M', '1005', '1000', 'kB'],
[1005000, '1M', '1.01', '1', 'MB'],
// limit in KiB
[1025, '1Ki', '1025', '1024', 'bytes'],
[1029, '1Ki', '1029', '1024', 'bytes'],
[1030, '1Ki', '1.01', '1', 'KiB'],
[1048577, '1024Ki', '1048577', '1048576', 'bytes'],
[1053818, '1024Ki', '1029.12', '1024', 'KiB'],
[1053819, '1024Ki', '1.01', '1', 'MiB'],
// limit in MiB
[1048577, '1Mi', '1048577', '1048576', 'bytes'],
[1053818, '1Mi', '1029.12', '1024', 'KiB'],
[1053819, '1Mi', '1.01', '1', 'MiB'],
];
}
/**
* @dataProvider provideMaxSizeExceededTests
*/
public function testMaxSizeExceeded($bytesWritten, $limit, $sizeAsString, $limitAsString, $suffix)
{
fseek($this->file, $bytesWritten - 1, SEEK_SET);
fwrite($this->file, '0');
fclose($this->file);
$constraint = new File([
'maxSize' => $limit,
'maxSizeMessage' => 'myMessage',
]);
$this->validator->validate($this->getFile($this->path), $constraint);
$this->buildViolation('myMessage')
->setParameter('{{ limit }}', $limitAsString)
->setParameter('{{ size }}', $sizeAsString)
->setParameter('{{ suffix }}', $suffix)
->setParameter('{{ file }}', '"'.$this->path.'"')
->setParameter('{{ name }}', '"'.basename($this->path).'"')
->setCode(File::TOO_LARGE_ERROR)
->assertRaised();
}
public function provideMaxSizeNotExceededTests()
{
return [
// limit in bytes
[1000, 1000],
[1000000, 1000000],
// limit in kB
[1000, '1k'],
[1000000, '1000k'],
// limit in MB
[1000000, '1M'],
// limit in KiB
[1024, '1Ki'],
[1048576, '1024Ki'],
// limit in MiB
[1048576, '1Mi'],
];
}
/**
* @dataProvider provideMaxSizeNotExceededTests
*/
public function testMaxSizeNotExceeded($bytesWritten, $limit)
{
fseek($this->file, $bytesWritten - 1, SEEK_SET);
fwrite($this->file, '0');
fclose($this->file);
$constraint = new File([
'maxSize' => $limit,
'maxSizeMessage' => 'myMessage',
]);
$this->validator->validate($this->getFile($this->path), $constraint);
$this->assertNoViolation();
}
public function testInvalidMaxSize()
{
$this->expectException('Symfony\Component\Validator\Exception\ConstraintDefinitionException');
$constraint = new File([
'maxSize' => '1abc',
]);
$this->validator->validate($this->path, $constraint);
}
public function provideBinaryFormatTests()
{
return [
[11, 10, null, '11', '10', 'bytes'],
[11, 10, true, '11', '10', 'bytes'],
[11, 10, false, '11', '10', 'bytes'],
// round(size) == 1.01kB, limit == 1kB
[ceil(1000 * 1.01), 1000, null, '1.01', '1', 'kB'],
[ceil(1000 * 1.01), '1k', null, '1.01', '1', 'kB'],
[ceil(1024 * 1.01), '1Ki', null, '1.01', '1', 'KiB'],
[ceil(1024 * 1.01), 1024, true, '1.01', '1', 'KiB'],
[ceil(1024 * 1.01 * 1000), '1024k', true, '1010', '1000', 'KiB'],
[ceil(1024 * 1.01), '1Ki', true, '1.01', '1', 'KiB'],
[ceil(1000 * 1.01), 1000, false, '1.01', '1', 'kB'],
[ceil(1000 * 1.01), '1k', false, '1.01', '1', 'kB'],
[ceil(1024 * 1.01 * 10), '10Ki', false, '10.34', '10.24', 'kB'],
];
}
/**
* @dataProvider provideBinaryFormatTests
*/
public function testBinaryFormat($bytesWritten, $limit, $binaryFormat, $sizeAsString, $limitAsString, $suffix)
{
fseek($this->file, $bytesWritten - 1, SEEK_SET);
fwrite($this->file, '0');
fclose($this->file);
$constraint = new File([
'maxSize' => $limit,
'binaryFormat' => $binaryFormat,
'maxSizeMessage' => 'myMessage',
]);
$this->validator->validate($this->getFile($this->path), $constraint);
$this->buildViolation('myMessage')
->setParameter('{{ limit }}', $limitAsString)
->setParameter('{{ size }}', $sizeAsString)
->setParameter('{{ suffix }}', $suffix)
->setParameter('{{ file }}', '"'.$this->path.'"')
->setParameter('{{ name }}', '"'.basename($this->path).'"')
->setCode(File::TOO_LARGE_ERROR)
->assertRaised();
}
public function testValidMimeType()
{
$file = new FileObject(__DIR__.'/Fixtures/blank.jpg');
$constraint = new File([
'mimeTypes' => ['image/png', 'image/jpeg'],
]);
$this->validator->validate($file, $constraint);
$this->assertNoViolation();
}
public function testValidWildcardMimeType()
{
$file = new FileObject(__DIR__.'/Fixtures/test.gif');
$constraint = new File([
'mimeTypes' => ['image/*'],
]);
$this->validator->validate($file, $constraint);
$this->assertNoViolation();
}
public function testInvalidMimeType()
{
$file = new FileObject(__DIR__.'/Fixtures/blank.pdf');
$constraint = new File([
'mimeTypes' => ['image/png', 'image/jpeg'],
'mimeTypesMessage' => 'myMessage',
]);
$this->validator->validate($file, $constraint);
$this->buildViolation('myMessage')
->setParameter('{{ type }}', '"application/pdf"')
->setParameter('{{ types }}', '"image/png", "image/jpeg"')
->setParameter('{{ file }}', '"'.__DIR__.'/Fixtures/blank.pdf'.'"')
->setParameter('{{ name }}', '"blank.pdf"')
->setCode(File::INVALID_MIME_TYPE_ERROR)
->assertRaised();
}
public function testInvalidWildcardMimeType()
{
$file = new FileObject(__DIR__.'/Fixtures/blank.pdf');
$constraint = new File([
'mimeTypes' => ['image/*', 'image/jpeg'],
'mimeTypesMessage' => 'myMessage',
]);
$this->validator->validate($file, $constraint);
$this->buildViolation('myMessage')
->setParameter('{{ type }}', '"application/pdf"')
->setParameter('{{ types }}', '"image/*", "image/jpeg"')
->setParameter('{{ file }}', '"'.__DIR__.'/Fixtures/blank.pdf'.'"')
->setParameter('{{ name }}', '"blank.pdf"')
->setCode(File::INVALID_MIME_TYPE_ERROR)
->assertRaised();
}
public function testDisallowEmpty()
{
ftruncate($this->file, 0);
$constraint = new File([
'disallowEmptyMessage' => 'myMessage',
]);
$this->validator->validate($this->getFile($this->path), $constraint);
$this->buildViolation('myMessage')
->setParameter('{{ file }}', '"'.$this->path.'"')
->setParameter('{{ name }}', '"'.basename($this->path).'"')
->setCode(File::EMPTY_ERROR)
->assertRaised();
}
/**
* @dataProvider uploadedFileErrorProvider
*/
public function testUploadedFileError($error, $message, array $params = [], $maxSize = null)
{
$file = new UploadedFile(tempnam(sys_get_temp_dir(), 'file-validator-test-'), 'originalName', 'mime', $error);
$constraint = new File([
$message => 'myMessage',
'maxSize' => $maxSize,
]);
$this->validator->validate($file, $constraint);
$this->buildViolation('myMessage')
->setParameters($params)
->setCode($error)
->assertRaised();
}
public function uploadedFileErrorProvider()
{
$tests = [
[(string) UPLOAD_ERR_FORM_SIZE, 'uploadFormSizeErrorMessage'],
[(string) UPLOAD_ERR_PARTIAL, 'uploadPartialErrorMessage'],
[(string) UPLOAD_ERR_NO_FILE, 'uploadNoFileErrorMessage'],
[(string) UPLOAD_ERR_NO_TMP_DIR, 'uploadNoTmpDirErrorMessage'],
[(string) UPLOAD_ERR_CANT_WRITE, 'uploadCantWriteErrorMessage'],
[(string) UPLOAD_ERR_EXTENSION, 'uploadExtensionErrorMessage'],
];
if (class_exists('Symfony\Component\HttpFoundation\File\UploadedFile')) {
// when no maxSize is specified on constraint, it should use the ini value
$tests[] = [(string) UPLOAD_ERR_INI_SIZE, 'uploadIniSizeErrorMessage', [
'{{ limit }}' => UploadedFile::getMaxFilesize() / 1048576,
'{{ suffix }}' => 'MiB',
]];
// it should use the smaller limitation (maxSize option in this case)
$tests[] = [(string) UPLOAD_ERR_INI_SIZE, 'uploadIniSizeErrorMessage', [
'{{ limit }}' => 1,
'{{ suffix }}' => 'bytes',
], '1'];
// access FileValidator::factorizeSizes() private method to format max file size
$reflection = new \ReflectionClass(\get_class(new FileValidator()));
$method = $reflection->getMethod('factorizeSizes');
$method->setAccessible(true);
list(, $limit, $suffix) = $method->invokeArgs(new FileValidator(), [0, UploadedFile::getMaxFilesize(), false]);
// it correctly parses the maxSize option and not only uses simple string comparison
// 1000M should be bigger than the ini value
$tests[] = [(string) UPLOAD_ERR_INI_SIZE, 'uploadIniSizeErrorMessage', [
'{{ limit }}' => $limit,
'{{ suffix }}' => $suffix,
], '1000M'];
// it correctly parses the maxSize option and not only uses simple string comparison
// 1000M should be bigger than the ini value
$tests[] = [(string) UPLOAD_ERR_INI_SIZE, 'uploadIniSizeErrorMessage', [
'{{ limit }}' => '0.1',
'{{ suffix }}' => 'MB',
], '100K'];
}
return $tests;
}
abstract protected function getFile($filename);
}