From 36536c94d279b189b822c852ab4e0ef612c25527 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Sun, 2 Feb 2020 18:36:34 +0100 Subject: [PATCH] [HttpClient] dont display any content when none has been collected --- .../HttpClient/DataCollector/HttpClientDataCollector.php | 8 +++++--- src/Symfony/Component/HttpClient/TraceableHttpClient.php | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php b/src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php index 30874c940daa..bdfbc8698e0c 100644 --- a/src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php +++ b/src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php @@ -145,13 +145,15 @@ private function collectOnClient(TraceableHttpClient $client): array $content = [$content]; } - $k = 'response_content'; + $content = ['response_content' => $content]; + } elseif (\is_array($content)) { + $content = ['response_json' => $content]; } else { - $k = 'response_json'; + $content = []; } $debugInfo = array_diff_key($info, $baseInfo); - $info = ['info' => $debugInfo] + array_diff_key($info, $debugInfo) + [$k => $content]; + $info = ['info' => $debugInfo] + array_diff_key($info, $debugInfo) + $content; unset($traces[$i]['info']); // break PHP reference used by TraceableHttpClient $traces[$i]['info'] = $this->cloneVar($info); $traces[$i]['options'] = $this->cloneVar($trace['options']); diff --git a/src/Symfony/Component/HttpClient/TraceableHttpClient.php b/src/Symfony/Component/HttpClient/TraceableHttpClient.php index a69398bb3f70..70e22091d695 100644 --- a/src/Symfony/Component/HttpClient/TraceableHttpClient.php +++ b/src/Symfony/Component/HttpClient/TraceableHttpClient.php @@ -37,7 +37,7 @@ public function __construct(HttpClientInterface $client) */ public function request(string $method, string $url, array $options = []): ResponseInterface { - $content = ''; + $content = null; $traceInfo = []; $this->tracedRequests[] = [ 'method' => $method,