From 44b45cbaf108ffff767895a426aa2d3ff714cdfd Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Tue, 12 May 2020 17:50:06 +0200 Subject: [PATCH] [Serializer] fix issue with PHP 8 --- .../Serializer/Normalizer/AbstractNormalizer.php | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php index a360dc2fc3b6..d89c4660bf94 100644 --- a/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php +++ b/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php @@ -386,11 +386,19 @@ protected function instantiateObject(array &$data, $class, array &$context, \Ref protected function denormalizeParameter(\ReflectionClass $class, \ReflectionParameter $parameter, $parameterName, $parameterData, array $context, $format = null) { try { - if (null !== $parameter->getClass()) { + if (\PHP_VERSION_ID < 70100 && null !== $parameterClass = $parameter->getClass()) { + $parameterClass = $parameterClass->name; + } elseif (\PHP_VERSION_ID >= 70100 && $parameter->hasType() && ($parameterType = $parameter->getType()) && !$parameterType->isBuiltin()) { + $parameterClass = $parameterType->getName(); + new \ReflectionClass($parameterClass); // throws a \ReflectionException if the class doesn't exist + } else { + $parameterClass = null; + } + + if (null !== $parameterClass) { if (!$this->serializer instanceof DenormalizerInterface) { - throw new LogicException(sprintf('Cannot create an instance of "%s" from serialized data because the serializer inject in "%s" is not a denormalizer.', $parameter->getClass(), static::class)); + throw new LogicException(sprintf('Cannot create an instance of "%s" from serialized data because the serializer inject in "%s" is not a denormalizer.', $parameterClass, static::class)); } - $parameterClass = $parameter->getClass()->getName(); return $this->serializer->denormalize($parameterData, $parameterClass, $format, $this->createChildContext($context, $parameterName, $format)); }