From b389b68c1fcef99de6c31fb5f261d949ff2723dc Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Sat, 29 Feb 2020 11:16:22 +0100 Subject: [PATCH 01/17] updated CHANGELOG for 3.4.38 --- CHANGELOG-3.4.md | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/CHANGELOG-3.4.md b/CHANGELOG-3.4.md index f68d58c65894..fc1d9aa398c2 100644 --- a/CHANGELOG-3.4.md +++ b/CHANGELOG-3.4.md @@ -7,6 +7,36 @@ in 3.4 minor versions. To get the diff for a specific change, go to https://github.com/symfony/symfony/commit/XXX where XXX is the change hash To get the diff between two versions, go to https://github.com/symfony/symfony/compare/v3.4.0...v3.4.1 +* 3.4.38 (2020-02-29) + + * bug #35781 [Form] NumberToLocalizedStringTransformer return int if scale = 0 (VincentLanglet) + * bug #35846 [Serializer] prevent method calls on null values (xabbuh) + * bug #35839 [Security] Allow switching to another user when already switched (chalasr) + * bug #35817 [DoctrineBridge] Use new Types::* constants and support new json type (fancyweb) + * bug #35707 [ExpressionLanguage] Fixed collisions of character operators with object properties (Andrej-in-ua) + * bug #35794 [DoctrineBridge][DoctrineExtractor] Fix indexBy with custom and some core types (fancyweb) + * bug #35787 [PhpUnitBridge] Use trait instead of extending deprecated class (marcello-moenkemeyer) + * bug #35792 [Security] Prevent TypeError in case RememberMetoken has no attached user (nikophil) + * bug #35772 [Config] don't throw on missing excluded paths (nicolas-grekas) + * bug #35774 [Ldap] force default network timeout (nicolas-grekas) + * bug #35702 [VarDumper] fixed DateCaster not displaying additional fields (Makdessi Alex) + * bug #35722 [HttpKernel] Set previous exception when rethrown from controller resolver (danut007ro) + * bug #35718 [HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI (nicolas-grekas) + * bug #35693 [Finder] Fix unix root dir issue (chr-hertel) + * bug #35696 [Console] Don't load same-namespace alternatives on exact match (chalasr) + * bug #35605 [HttpFoundation][FrameworkBundle] fix support for samesite in session cookies (fabpot) + * bug #35609 [DoctrineBridge] Fixed submitting ids with query limit or offset (HeahDude) + * bug #34123 [Form] Fix handling of empty_data's \Closure value in Date/Time form types (yceruto) + * bug #35546 [Validator] check for __get method existence if property is uninitialized (alekitto) + * bug #35332 [Yaml][Inline] Fail properly on empty object tag and empty const tag (fancyweb) + * bug #35489 [PhpUnitBridge] Fix running skipped tests expecting only deprecations (chalasr) + * bug #35161 [FrameworkBundle] Check non-null type for numeric type (Arman-Hosseini) + * bug #34059 [DomCrawler] Skip disabled fields processing in Form (sbogx) + * bug #34114 [Console] SymonfyStyle - Check value isset to avoid PHP notice (leevigraham) + * bug #35557 [Config] dont catch instances of Error (nicolas-grekas) + * bug #35532 [Validator] fix access to uninitialized property when getting value (greedyivan) + * bug #35305 [HttpKernel] Fix stale-if-error behavior, add tests (mpdude) + * 3.4.37 (2020-01-21) * bug #35065 [Security] Use supportsClass in addition to UnsupportedUserException (linaori) From 42be173dfefd7fc3ac8fb82f5015f432428d8ba9 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Sat, 29 Feb 2020 11:16:34 +0100 Subject: [PATCH 02/17] update CONTRIBUTORS for 3.4.38 --- CONTRIBUTORS.md | 178 +++++++++++++++++++++++++++++++----------------- 1 file changed, 114 insertions(+), 64 deletions(-) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index aea14fb7e6c5..468c90ad49d1 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -17,9 +17,9 @@ Symfony is the result of the work of many people who made the code better - Maxime Steinhausser (ogizanagi) - Ryan Weaver (weaverryan) - Javier Eguiluz (javier.eguiluz) + - Grégoire Pineau (lyrixx) - Jakub Zalas (jakubzalas) - Roland Franssen (ro0) - - Grégoire Pineau (lyrixx) - Johannes S (johannes) - Kris Wallsmith (kriswallsmith) - Yonel Ceruto (yonelceruto) @@ -27,31 +27,31 @@ Symfony is the result of the work of many people who made the code better - Abdellatif Ait boudad (aitboudad) - Samuel ROZE (sroze) - Romain Neutron (romain) + - Wouter de Jong (wouterj) - Pascal Borreli (pborreli) - - Wouter De Jong (wouterj) + - Thomas Calvet (fancyweb) - Joseph Bielawski (stloyd) - Alexander M. Turek (derrabus) - Karma Dordrak (drak) - - Thomas Calvet (fancyweb) - Lukas Kahwe Smith (lsmith) - Martin Hasoň (hason) - Hamza Amrouche (simperfit) - - Jeremy Mikola (jmikola) - Jules Pietri (heah) - - Jean-François Simon (jfsimon) + - Jeremy Mikola (jmikola) - Jérémy DERUSSÉ (jderusse) + - Jean-François Simon (jfsimon) - Benjamin Eberlei (beberlei) - Igor Wiedler (igorw) - Eriksen Costa (eriksencosta) - Guilhem Niot (energetick) - - Sarah Khalil (saro0h) - Tobias Nyholm (tobias) + - Sarah Khalil (saro0h) - Jonathan Wage (jwage) - Lynn van der Berg (kjarli) - Diego Saint Esteben (dosten) + - Matthias Pigulla (mpdude) - Alexandre Salomé (alexandresalome) - William Durand (couac) - - Matthias Pigulla (mpdude) - Pierre du Plessis (pierredup) - ornicar - Dany Maillard (maidmaid) @@ -59,29 +59,29 @@ Symfony is the result of the work of many people who made the code better - stealth35 ‏ (stealth35) - Alexander Mols (asm89) - Konstantin Myakshin (koc) + - Grégoire Paris (greg0ire) - Bulat Shakirzyanov (avalanche123) - Valentin Udaltsov (vudaltsov) - - Grégoire Paris (greg0ire) + - Kevin Bond (kbond) - Saša Stamenković (umpirsky) - Peter Rehm (rpet) - - Kevin Bond (kbond) - Henrik Bjørnskov (henrikbjorn) - Miha Vrhovnik + - Gabriel Ostrolucký (gadelat) - Diego Saint Esteben (dii3g0) - Gábor Egyed (1ed) - - Gabriel Ostrolucký (gadelat) - Titouan Galopin (tgalopin) - - Konstantin Kudryashov (everzet) - David Maicher (dmaicher) + - Konstantin Kudryashov (everzet) - Bilal Amarni (bamarni) - Mathieu Piot (mpiot) - Vladimir Reznichenko (kalessil) + - Jan Schädlich (jschaedl) - Florin Patan (florinpatan) - Jáchym Toušek (enumag) - Andrej Hudec (pulzarraider) - Michel Weimerskirch (mweimerskirch) - Issei Murasawa (issei_m) - - Jan Schädlich (jschaedl) - Eric Clemmons (ericclemmons) - Charles Sarrazin (csarrazi) - Christian Raue @@ -96,20 +96,20 @@ Symfony is the result of the work of many people who made the code better - Lee McDermott - Brandon Turner - Luis Cordova (cordoval) + - Jérôme Tamarelle (gromnan) - Daniel Holmes (dholmes) - Toni Uebernickel (havvg) + - Fran Moreno (franmomu) - Bart van den Burg (burgov) - Jordan Alliot (jalliot) - - Jérôme Tamarelle (gromnan) - John Wards (johnwards) - - Fran Moreno (franmomu) - Antoine Hérault (herzult) - Paráda József (paradajozsef) - Arnaud Le Blanc (arnaud-lb) - Maxime STEINHAUSSER + - Baptiste Clavié (talus) - Michal Piotrowski (eventhorizon) - Tim Nagel (merk) - - Baptiste Clavié (talus) - Chris Wilkinson (thewilkybarkid) - Brice BERNARD (brikou) - marc.weistroff @@ -133,10 +133,10 @@ Symfony is the result of the work of many people who made the code better - Tugdual Saunier (tucksaun) - excelwebzone - Gordon Franke (gimler) + - Joel Wurtz (brouznouf) - Fabien Pennequin (fabienpennequin) - Théo FIDRY (theofidry) - Eric GELOEN (gelo) - - Joel Wurtz (brouznouf) - Lars Strojny (lstrojny) - Jannik Zschiesche (apfelbox) - Robert Schönthal (digitalkaoz) @@ -145,6 +145,8 @@ Symfony is the result of the work of many people who made the code better - Gabriel Caruso (carusogabriel) - Stefano Sala (stefano.sala) - Evgeniy (ewgraf) + - Massimiliano Arione (garak) + - Julien Falque (julienfalque) - Vincent AUBERT (vincent) - Juti Noppornpitak (shiroyuki) - Alexander Schranz (alexander-schranz) @@ -155,7 +157,6 @@ Symfony is the result of the work of many people who made the code better - Hidenori Goto (hidenorigoto) - Andréia Bohner (andreia) - Yanick Witschi (toflar) - - Julien Falque (julienfalque) - Arnaud Kleinpeter (nanocom) - Guilherme Blanco (guilhermeblanco) - SpacePossum @@ -163,12 +164,12 @@ Symfony is the result of the work of many people who made the code better - Jérémie Augustin (jaugustin) - François-Xavier de Guillebon (de-gui_f) - Oleg Voronkovich + - Alessandro Chitolina (alekitto) - Philipp Wahala (hifi) - - Massimiliano Arione (garak) - Rafael Dohms (rdohms) - jwdeitch - Mikael Pajunen - - Alessandro Chitolina (alekitto) + - Arman Hosseini (arman) - Niels Keurentjes (curry684) - Vyacheslav Pavlov - Richard van Laak (rvanlaak) @@ -178,9 +179,9 @@ Symfony is the result of the work of many people who made the code better - jeremyFreeAgent (jeremyfreeagent) - Rouven Weßling (realityking) - Jérôme Parmentier (lctrs) + - Andreas Schempp (aschempp) - Clemens Tolboom - Helmer Aaviksoo - - Arman Hosseini (arman) - Hiromi Hishida (77web) - Matthieu Ouellette-Vachon (maoueh) - Michał Pipa (michal.pipa) @@ -193,7 +194,6 @@ Symfony is the result of the work of many people who made the code better - GDIBass - Samuel NELA (snela) - Ben Davies (bendavies) - - Andreas Schempp (aschempp) - James Halsall (jaitsu) - Matthieu Napoli (mnapoli) - Florent Mata (fmata) @@ -226,11 +226,13 @@ Symfony is the result of the work of many people who made the code better - Stadly - Stepan Anchugov (kix) - bronze1man + - Filippo Tessarotto (slamdunk) - sun (sun) - Larry Garfield (crell) - Nikolay Labinskiy (e-moe) - Martin Schuhfuß (usefulthink) - apetitpa + - Antoine Makdessi (amakdessi) - Matthieu Bontemps (mbontemps) - apetitpa - Pierre Minnieur (pminnieur) @@ -246,6 +248,7 @@ Symfony is the result of the work of many people who made the code better - jeff - John Kary (johnkary) - Jan Rosier (rosier) + - Przemysław Bogusz (przemyslaw-bogusz) - Justin Hileman (bobthecow) - Blanchon Vincent (blanchonvincent) - Michele Orselli (orso) @@ -260,9 +263,11 @@ Symfony is the result of the work of many people who made the code better - Tristan Darricau (nicofuma) - Victor Bocharsky (bocharsky_bw) - Tomas Norkūnas (norkunas) + - Wouter J + - Smaine Milianni (ismail1432) - Marcel Beerta (mazen) + - Christopher Hertel (chertel) - Ruud Kamphuis (ruudk) - - Antoine Makdessi (amakdessi) - Maxime Helias (maxhelias) - Pavel Batanov (scaytrase) - Mantis Development @@ -275,7 +280,9 @@ Symfony is the result of the work of many people who made the code better - julien pauli (jpauli) - Lorenz Schori - Sébastien Lavoie (lavoiesl) + - Ahmed TAILOULOUTE (ahmedtai) - Dariusz + - Saif (╯°□°)╯ (azjezz) - Dmitrii Poddubnyi (karser) - Michael Babker (mbabker) - Francois Zaninotto @@ -289,7 +296,6 @@ Symfony is the result of the work of many people who made the code better - Danny Berger (dpb587) - Antonio J. García Lagar (ajgarlag) - Adam Prager (padam87) - - Przemysław Bogusz (przemyslaw-bogusz) - Benoît Burnichon (bburnichon) - Maciej Malarz (malarzm) - Roman Marintšenko (inori) @@ -307,19 +313,17 @@ Symfony is the result of the work of many people who made the code better - Jordan Samouh (jordansamouh) - Baptiste Lafontaine (magnetik) - Jakub Kucharovic (jkucharovic) + - Loick Piera (pyrech) - Uwe Jäger (uwej711) - Eugene Leonovich (rybakit) - - Filippo Tessarotto - Joseph Rouff (rouffj) - Félix Labrecque (woodspire) - GordonsLondon - Quynh Xuan Nguyen (xuanquynh) - Jan Sorgalla (jsor) - Ray - - Smaine Milianni (ismail1432) - Chekote - François Pluchino (francoispluchino) - - Christopher Hertel (chertel) - Thomas Adam - Jhonny Lidfors (jhonne) - Diego Agulló (aeoris) @@ -327,6 +331,7 @@ Symfony is the result of the work of many people who made the code better - Bob den Otter (bopp) - Thomas Schulz (king2500) - Frank de Jonge (frenkynet) + - Jeroen Spee (jeroens) - Nikita Konstantinov - Wodor Wodorski - Thomas Lallement (raziel057) @@ -339,6 +344,7 @@ Symfony is the result of the work of many people who made the code better - Robert Kiss (kepten) - Zan Baldwin (zanderbaldwin) - Roumen Damianoff (roumen) + - Emanuele Panzeri (thepanz) - Kim Hemsø Rasmussen (kimhemsoe) - Pascal Luna (skalpa) - Wouter Van Hecke @@ -352,7 +358,7 @@ Symfony is the result of the work of many people who made the code better - Christian Schmidt - Patrick Landolt (scube) - MatTheCat - - Loick Piera (pyrech) + - Vilius Grigaliūnas - David Badura (davidbadura) - Chad Sikorra (chadsikorra) - Chris Smith (cs278) @@ -371,8 +377,8 @@ Symfony is the result of the work of many people who made the code better - Andrey Esaulov (andremaha) - Grégoire Passault (gregwar) - Jerzy Zawadzki (jzawadzki) - - Wouter J - Ismael Ambrosi (iambrosi) + - Craig Duncan (duncan3dc) - Emmanuel BORGES (eborges78) - Aurelijus Valeiša (aurelijus) - Jan Decavele (jandc) @@ -386,16 +392,19 @@ Symfony is the result of the work of many people who made the code better - Francesc Rosàs (frosas) - Romain Pierre (romain-pierre) - Julien Galenski (ruian) + - Michael Käfer (michael_kaefer) - Bongiraud Dominique - janschoenherr - Emanuele Gaspari (inmarelibero) - Dariusz Rumiński - Berny Cantos (xphere81) + - Laurent VOULLEMIER (lvo) - Thierry Thuon (lepiaf) - Ricard Clau (ricardclau) - Mark Challoner (markchalloner) - Philippe Segatori - Gennady Telegin (gtelegin) + - Mathias Arlaud (mtarld) - Erin Millard - Artur Melo (restless) - Matthew Lewinski (lewinski) @@ -404,6 +413,7 @@ Symfony is the result of the work of many people who made the code better - Nicolas LEFEVRE (nicoweb) - alquerci - Olivier Dolbeau (odolbeau) + - Oleg Andreyev - Mateusz Sip (mateusz_sip) - Francesco Levorato - Vitaliy Zakharov (zakharovvi) @@ -416,22 +426,22 @@ Symfony is the result of the work of many people who made the code better - Artur Eshenbrener - Timo Bakx (timobakx) - Thomas Perez (scullwm) - - Saif Eddin Gmati (azjezz) - Felix Labrecque - Yaroslav Kiliba - Terje Bråten - Robbert Klarenbeek (robbertkl) - Eric Masoero (eric-masoero) + - Denis Brumann (dbrumann) - JhonnyL - hossein zolfi (ocean) - Clément Gautier (clementgautier) - Bastien Jaillot (bastnic) - Dāvis Zālītis (k0d3r1s) - - Emanuele Panzeri (thepanz) - Sanpi - Eduardo Gulias (egulias) - giulio de donato (liuggio) - ShinDarth + - Alan Poulain - Stéphane PY (steph_py) - Philipp Kräutli (pkraeutli) - Grzegorz (Greg) Zdanowski (kiler129) @@ -443,7 +453,6 @@ Symfony is the result of the work of many people who made the code better - Alex Bowers - Philipp Cordes - Costin Bereveanu (schniper) - - Vilius Grigaliūnas - Loïc Chardonnet (gnusat) - Marek Kalnik (marekkalnik) - Vyacheslav Salakhutdinov (megazoll) @@ -488,7 +497,6 @@ Symfony is the result of the work of many people who made the code better - Christophe L. (christophelau) - Sander Toonen (xatoo) - Anthon Pang (robocoder) - - Michael Käfer (michael_kaefer) - Sébastien Santoro (dereckson) - Brian King - Michel Salib (michelsalib) @@ -498,27 +506,28 @@ Symfony is the result of the work of many people who made the code better - Alexandru Furculita (afurculita) - Valentin Jonovs (valentins-jonovs) - Guilhem N (guilhemn) - - Laurent VOULLEMIER (lvo) - Jeanmonod David (jeanmonod) - Christopher Davis (chrisguitarguy) - Webnet team (webnet) - Farhad Safarov - - Jeroen Spee (jeroens) - Jan Schumann - Niklas Fiekas - Markus Bachmann (baachi) - Kévin THERAGE (kevin_therage) + - Erkhembayar Gantulga (erheme318) + - Islam93 - lancergr - Mihai Stancu - Ivan Nikolaev (destillat) - Gildas Quéméner (gquemener) - - Oleg Andreyev - Alessandro Lai (jean85) - Desjardins Jérôme (jewome62) - Arturs Vonda - Josip Kruslin - Matthew Smeets + - Toni Rudolf (toooni) - Asmir Mustafic (goetas) + - Nicolas Philippe (nikophil) - vagrant - Aurimas Niekis (gcds) - EdgarPE @@ -531,6 +540,7 @@ Symfony is the result of the work of many people who made the code better - Chris Sedlmayr (catchamonkey) - Kamil Kokot (pamil) - Seb Koelen + - Antonio Pauletich (x-coder264) - Christoph Mewes (xrstf) - Vitaliy Tverdokhlib (vitaliytv) - Ariel Ferrandini (aferrandini) @@ -542,7 +552,6 @@ Symfony is the result of the work of many people who made the code better - Gonzalo Vilaseca (gonzalovilaseca) - Tarmo Leppänen (tarlepp) - Marcin Sikoń (marphi) - - Denis Brumann (dbrumann) - Dominik Zogg (dominik.zogg) - Marek Pietrzak - Luc Vieillescazes (iamluc) @@ -552,7 +561,6 @@ Symfony is the result of the work of many people who made the code better - Gintautas Miselis - Rob Bast - Roberto Espinoza (respinoza) - - Alan Poulain - Soufian EZ-ZANTAR (soezz) - Zander Baldwin - Gocha Ossinkine (ossinkine) @@ -595,7 +603,6 @@ Symfony is the result of the work of many people who made the code better - Roy Van Ginneken (rvanginneken) - ondrowan - Barry vd. Heuvel (barryvdh) - - Craig Duncan (duncan3dc) - Evan S Kaufman (evanskaufman) - mcben - Jérôme Vieilledent (lolautruche) @@ -606,6 +613,7 @@ Symfony is the result of the work of many people who made the code better - Remi Collet - Vicent Soria Durá (vicentgodella) - Michael Moravec + - Leevi Graham (leevigraham) - Anthony Ferrara - Ioan Negulescu - Jakub Škvára (jskvara) @@ -631,7 +639,9 @@ Symfony is the result of the work of many people who made the code better - Nate (frickenate) - Timothée Barray (tyx) - jhonnyL + - Jacek Jędrzejewski (jacek.jedrzejewski) - sasezaki + - Bozhidar Hristov (warxcell) - Dawid Pakuła (zulusx) - Florian Rey (nervo) - Rodrigo Borrego Bernabé (rodrigobb) @@ -658,13 +668,16 @@ Symfony is the result of the work of many people who made the code better - Jeremy Benoist - fritzmg - Lenar Lõhmus + - Ion Bazan (ionbazan) - Benjamin Laugueux (yzalis) - Zach Badgett (zachbadgett) + - Chi-teck - Aurélien Fredouelle - Pavel Campr (pcampr) - Andrii Dembitskyi - Johnny Robeson (johnny) - Marko Kaznovac (kaznovac) + - Guilliam Xavier - Disquedur - Michiel Boeckaert (milio) - Geoffrey Tran (geoff) @@ -685,6 +698,7 @@ Symfony is the result of the work of many people who made the code better - Dmitry Simushev - Joe Bennett (kralos) - alcaeus + - Thomas Talbot (ioni) - Fred Cox - vitaliytv - Philippe Segatori @@ -703,6 +717,7 @@ Symfony is the result of the work of many people who made the code better - Konstantin S. M. Möllers (ksmmoellers) - James Johnston - Sinan Eldem + - BoShurik - Alexandre Dupuy (satchette) - Malte Blättermann - Simeon Kolev (simeon_kolev9) @@ -725,12 +740,12 @@ Symfony is the result of the work of many people who made the code better - Javier López (loalf) - Reinier Kip - Geoffrey Brier (geoffrey-brier) + - Alexandre Parent - Vladimir Tsykun - Dustin Dobervich (dustin10) - dantleech - Anne-Sophie Bachelard (annesophie) - Sebastian Marek (proofek) - - Erkhembayar Gantulga (erheme318) - zenmate - Michal Trojanowski - David Fuhr @@ -747,7 +762,6 @@ Symfony is the result of the work of many people who made the code better - adev - Stefan Warman - Arkadius Stefanski (arkadius) - - Antonio Pauletich (x-coder264) - Tristan Maindron (tmaindron) - Behnoush Norouzali (behnoush) - Wesley Lancel @@ -759,10 +773,10 @@ Symfony is the result of the work of many people who made the code better - Miquel Rodríguez Telep (mrtorrent) - Sergey Kolodyazhnyy (skolodyazhnyy) - umpirski + - Artem Lopata - M. Vondano - Quentin de Longraye (quentinus95) - Chris Heng (gigablah) - - Islam93 - Shaun Simmons (simshaun) - Richard Bradley - Ulumuddin Yunus (joenoez) @@ -852,7 +866,6 @@ Symfony is the result of the work of many people who made the code better - Yuen-Chi Lian - Tarjei Huse (tarjei) - Besnik Br - - Toni Rudolf (toooni) - Jose Gonzalez - Jonathan (jls-esokia) - Oleksii Zhurbytskyi @@ -871,12 +884,12 @@ Symfony is the result of the work of many people who made the code better - Andrew Tchircoff (andrewtch) - michaelwilliams - 1emming - - Leevi Graham (leevigraham) - Nykopol (nykopol) - Tri Pham (phamuyentri) - Jordan Deitch - Casper Valdemar Poulsen - Josiah (josiah) + - Guillaume Verstraete (versgui) - Greg ORIOL - Joschi Kuphal - John Bohn (jbohn) @@ -890,16 +903,17 @@ Symfony is the result of the work of many people who made the code better - fedor.f - Yosmany Garcia (yosmanyga) - Wouter de Wild + - Trevor North - Degory Valentine - izzyp - Benoit Lévêque (benoit_leveque) - Jeroen Fiege (fieg) - Krzysiek Łabuś - Xavier Lacot (xavier) + - Jon Dufresne - possum - Denis Zunke (donalberto) - Ahmadou Waly Ndiaye (waly) - - Ahmed TAILOULOUTE (ahmedtai) - Jonathan Johnson (jrjohnson) - Olivier Maisonneuve (olineuve) - Pedro Miguel Maymone de Resende (pedroresende) @@ -937,7 +951,6 @@ Symfony is the result of the work of many people who made the code better - Roy Klutman (royklutman) - Sofiane HADDAG (sofhad) - frost-nzcr4 - - Bozhidar Hristov - Laurent Bassin (lbassin) - andrey1s - Abhoryo @@ -954,17 +967,20 @@ Symfony is the result of the work of many people who made the code better - Julie Hourcade (juliehde) - Dmitry Parnas (parnas) - Paul LE CORRE + - Daniel Gorgan - Tony Malzhacker - Mathieu MARCHOIS - Cyril Quintin (cyqui) - Gerard van Helden (drm) - Johnny Peck (johnnypeck) + - Stefan Kruppa - Ivan Menshykov - David Romaní - Patrick Allaert - Gustavo Falco (gfalco) - Matt Robinson (inanimatt) - Kristof Van Cauwenbergh (kristofvc) + - Peter Bowyer (pbowyer) - Aleksey Podskrebyshev - Calin Mihai Pristavu - David Marín Carreño (davefx) @@ -986,8 +1002,6 @@ Symfony is the result of the work of many people who made the code better - Dmytro Boiko (eagle) - Shin Ohno (ganchiku) - Geert De Deckere (geertdd) - - Ion Bazan (ionbazan) - - Jacek Jędrzejewski (jacek.jedrzejewski) - Jan Kramer (jankramer) - abdul malik ikhsan (samsonasik) - Henry Snoek (snoek09) @@ -995,9 +1009,9 @@ Symfony is the result of the work of many people who made the code better - Simone Di Maulo (toretto460) - Christian Morgan - Alexander Miehe (engerim) + - Jesse Rushlow (geeshoe) - Morgan Auchede (mauchede) - Sascha Dens (saschadens) - - Chi-teck - Don Pinkster - Maksim Muruev - Emil Einarsson @@ -1023,7 +1037,6 @@ Symfony is the result of the work of many people who made the code better - Marcos Gómez Vilches (markitosgv) - Matthew Davis (mdavis1982) - Markus S. (staabm) - - Guilliam Xavier - Maks - Antoine LA - den @@ -1046,7 +1059,9 @@ Symfony is the result of the work of many people who made the code better - Koen Kuipers - datibbaw - Erik Saunier (snickers) + - Thiago Cordeiro (thiagocordeiro) - Rootie + - Alireza Mirsepassi (alirezamirsepassi) - Daniel Alejandro Castro Arellano (lexcast) - sensio - Thomas Jarrand @@ -1060,7 +1075,6 @@ Symfony is the result of the work of many people who made the code better - Valérian Galliat - d-ph - Renan Taranto (renan-taranto) - - Thomas Talbot (ioni) - Rikijs Murgs - Uladzimir Tsykun - Ben Ramsey (ramsey) @@ -1077,11 +1091,14 @@ Symfony is the result of the work of many people who made the code better - neghmurken - xaav - Mahmoud Mostafa (mahmoud) - - Mathias Arlaud (mtarld) + - Antonio Jose Cerezo (ajcerezo) + - Baptiste Leduc (korbeil) - Ahmed Abdou - Daniel Iwaniec + - Thomas Ferney - Pieter - Michael Tibben + - Hallison Boaventura (hallisonboaventura) - Billie Thompson - Ganesh Chandrasekaran - Sander Marechal @@ -1093,6 +1110,8 @@ Symfony is the result of the work of many people who made the code better - EStyles (insidestyles) - kevin.nadin - jean pasqualini (darkilliant) + - Iliya Miroslavov Iliev (i.miroslavov) + - Safonov Nikita (ns3777k) - Ross Motley (rossmotley) - ttomor - Mei Gwilym (meigwilym) @@ -1105,6 +1124,7 @@ Symfony is the result of the work of many people who made the code better - Nicolas Le Goff (nlegoff) - Ben Oman - Chris de Kok + - Lorenzo Millucci - Andreas Kleemann - Manuele Menozzi - zairig imad (zairigimad) @@ -1139,11 +1159,14 @@ Symfony is the result of the work of many people who made the code better - Wojciech Sznapka - Luis Pabon (luispabon) - Gavin Staniforth + - Anna Filina (afilina) - Ksaveras Šakys (xawiers) - Ariel J. Birnbaum + - Patrick Luca Fazzi (ap3ir0n) - Danijel Obradović - Pablo Borowicz - Mathieu Santostefano + - Michel Hunziker - Arjan Keeman - Máximo Cuadros (mcuadros) - Lukas Mencl @@ -1175,13 +1198,13 @@ Symfony is the result of the work of many people who made the code better - mlazovla - Alejandro Diaz Torres - Max Beutel + - Jan Vernieuwe (vernija) - Antanas Arvasevicius - Pierre Dudoret - Thomas - Maximilian Berghoff (electricmaxxx) - nacho - Piotr Antosik (antek88) - - Artem Lopata - Vedran Mihočinec (v-m-i) - Sergey Novikov (s12v) - creiner @@ -1199,11 +1222,11 @@ Symfony is the result of the work of many people who made the code better - HypeMC - jfcixmedia - Dominic Tubach - - Nicolas Philippe (nikophil) - Nikita Konstantinov - Martijn Evers - Vitaliy Ryaboy (vitaliy) - Benjamin Paap (benjaminpaap) + - Claus Due (namelesscoder) - Christian - Denis Golubovskiy (bukashk0zzz) - Sergii Smertin (nfx) @@ -1235,6 +1258,7 @@ Symfony is the result of the work of many people who made the code better - Jakub Sacha - Olaf Klischat - orlovv + - Andrey Sevastianov - Claude Dioudonnat - Jonathan Hedstrom - Peter Smeets (darkspartan) @@ -1243,7 +1267,7 @@ Symfony is the result of the work of many people who made the code better - Robert Meijers - James Sansbury - Marcin Chwedziak - - Alexandre Parent + - Benjamin - hjkl - Tony Cosentino (tony-co) - Dan Wilga @@ -1288,14 +1312,17 @@ Symfony is the result of the work of many people who made the code better - Yannick - Vladimir Luchaninov (luchaninov) - spdionis + - maxime.perrimond - rchoquet - gitlost - Taras Girnyk + - Arun Philip - Rémi Leclerc - Jan Vernarsky - Amine Yakoubi - Eduardo García Sanz (coma) - Sergio (deverad) + - Makdessi Alex - James Gilliland - fduch (fduch) - Stuart Fyfe @@ -1315,6 +1342,7 @@ Symfony is the result of the work of many people who made the code better - Roger Webb - Dmitriy Simushev - Pawel Smolinski + - Tomasz (timitao) - Oxan van Leeuwen - pkowalczyk - Soner Sayakci @@ -1329,6 +1357,7 @@ Symfony is the result of the work of many people who made the code better - Derek Lambert - MightyBranch - Kacper Gunia (cakper) + - Jérôme Tamarelle (jtamarelle-prismamedia) - Peter Thompson (petert82) - error56 - Felicitus @@ -1363,8 +1392,10 @@ Symfony is the result of the work of many people who made the code better - Mario Young - Ilia (aliance) - Chris McCafferty (cilefen) + - Florian Hermann (fhermann) - Mo Di (modi) - Pablo Schläpfer + - Patrick Berenschot - SuRiKmAn - Gert de Pagter - Jelte Steijaert (jelte) @@ -1384,6 +1415,7 @@ Symfony is the result of the work of many people who made the code better - Justin Reherman (jreherman) - Rubén Calvo (rubencm) - Abdul.Mohsen B. A. A + - Peter Jaap Blaakmeer - Swen van Zanten - Benoît Burnichon - pthompson @@ -1399,6 +1431,7 @@ Symfony is the result of the work of many people who made the code better - Kévin Gomez (kevin) - Mihai Nica (redecs) - Andrei Igna + - Adam Prickett - azine - Dawid Sajdak - Ludek Stepan @@ -1406,6 +1439,7 @@ Symfony is the result of the work of many people who made the code better - Craig Menning (cmenning) - Balázs Benyó (duplabe) - Erika Heidi Reinaldo (erikaheidi) + - Kyryll Maesh (gauss) - Pierre Tachoire (krichprollsch) - Marc J. Schmidt (marcjs) - František Maša @@ -1460,6 +1494,7 @@ Symfony is the result of the work of many people who made the code better - Antal Áron (antalaron) - Vašek Purchart (vasek-purchart) - Janusz Jabłoński (yanoosh) + - Ivan Grigoriev - Fleuv - Sandro Hopf - Łukasz Makuch @@ -1477,8 +1512,8 @@ Symfony is the result of the work of many people who made the code better - Philip Frank - David Brooks - Lance McNearney - - Guillaume Verstraete - Giorgio Premi + - Aurélien Fontaine - ncou - Ian Carroll - caponica @@ -1488,6 +1523,7 @@ Symfony is the result of the work of many people who made the code better - Pete Mitchell (peterjmit) - Tom Corrigan (tomcorrigan) - Luis Galeas + - Bogdan Scordaliu - Martin Pärtel - Daniel Rotter (danrot) - Frédéric Bouchery (fbouchery) @@ -1497,6 +1533,7 @@ Symfony is the result of the work of many people who made the code better - WedgeSama - Felds Liscia - Chihiro Adachi (chihiro-adachi) + - Axel Guckelsberger (guite) - Raphaëll Roussel - Tadcka - Beth Binkovitz @@ -1527,6 +1564,7 @@ Symfony is the result of the work of many people who made the code better - Arnaud CHASSEUX - tuqqu - Wojciech Gorczyca + - Neagu Cristian-Doru (cristian-neagu) - Rafał Muszyński (rafmus90) - Sébastien Decrême (sebdec) - Timothy Anido (xanido) @@ -1553,6 +1591,7 @@ Symfony is the result of the work of many people who made the code better - Nouhail AL FIDI (alfidi) - Fabian Steiner (fabstei) - Felipy Tavares Amorim (felipyamorim) + - Guillaume Loulier (guikingone) - Klaus Silveira (klaussilveira) - Thomas Chmielowiec (chmielot) - Jānis Lukss @@ -1588,12 +1627,12 @@ Symfony is the result of the work of many people who made the code better - Benhssaein Youssef - Benjamin Bender - Jared Farrish - - Trevor North - karl.rixon - raplider - Konrad Mohrfeldt - Lance Chen - Ciaran McNulty (ciaranmcnulty) + - Dominik Piekarski (dompie) - Andrew (drew) - kor3k kor3k (kor3k) - Stelian Mocanita (stelian) @@ -1607,6 +1646,7 @@ Symfony is the result of the work of many people who made the code better - Hoffmann András - LubenZA - Olivier + - knezmilos13 - Cyril PASCAL - Michael Bessolov - pscheit @@ -1680,6 +1720,7 @@ Symfony is the result of the work of many people who made the code better - Ikhsan Agustian - Arnau González (arnaugm) - Simon Bouland (bouland) + - Dmitry Pigin (dotty) - Jibé Barth (jibbarth) - Matthew Foster (mfoster) - Reyo Stallenberg (reyostallenberg) @@ -1697,7 +1738,6 @@ Symfony is the result of the work of many people who made the code better - stloyd - Andreas - Chris Tickner - - BoShurik - Andrew Coulton - Ulugbek Miniyarov - Jeremy Benoist @@ -1718,7 +1758,6 @@ Symfony is the result of the work of many people who made the code better - Eric Schildkamp - Andreas - Markus - - Daniel Gorgan - kernig - Thomas Chmielowiec - shdev @@ -1762,9 +1801,9 @@ Symfony is the result of the work of many people who made the code better - Andrey Helldar (helldar) - Karim Cassam Chenaï (ka) - Maksym Slesarenko (maksym_slesarenko) + - Marcello Mönkemeyer (marcello-moenkemeyer) - Michal Kurzeja (mkurzeja) - Nicolas Bastien (nicolas_bastien) - - Peter Bowyer (pbowyer) - Nikola Svitlica (thecelavi) - Denis (yethee) - Andrew Zhilin (zhil) @@ -1775,6 +1814,7 @@ Symfony is the result of the work of many people who made the code better - Normunds - Luiz “Felds” Liscia - Thomas Rothe + - Adrien Wilmet - Martin - nietonfir - alefranz @@ -1867,6 +1907,7 @@ Symfony is the result of the work of many people who made the code better - gedrox - Bohan Yang - Alan Bondarchuk + - Pchol - dropfen - Andrey Chernykh - Edvinas Klovas @@ -1889,6 +1930,7 @@ Symfony is the result of the work of many people who made the code better - AmsTaFF (amstaff) - Simon Müller (boscho) - Yannick Bensacq (cibou) + - Cyrille Bourgois (cyrilleb) - Damien (damien_vauchel) - Frédéric G. Marand (fgm) - Freek Van der Herten (freekmurze) @@ -1909,6 +1951,7 @@ Symfony is the result of the work of many people who made the code better - Ahmed Hannachi (tiecoders) - Vincent LEFORT (vlefort) - Walid BOUGHDIRI (walidboughdiri) + - Wim Molenberghs (wimm) - Darryl Hein (xmmedia) - Sadicov Vladimir (xtech) - Kevin EMO (zarcox) @@ -1944,6 +1987,7 @@ Symfony is the result of the work of many people who made the code better - Martin Mayer (martin) - Grzegorz Łukaszewicz (newicz) - Jonny Schmid (schmidjon) + - Ashura - Götz Gottwald - Veres Lajos - Nick Chiu @@ -2015,11 +2059,13 @@ Symfony is the result of the work of many people who made the code better - Achilles Kaloeridis (achilles) - Adria Lopez (adlpz) - Aaron Scherer (aequasi) + - baron (bastien) - Rosio (ben-rosio) - Simon Paarlberg (blamh) - Jeroen Thora (bolle) - Brieuc THOMAS (brieucthomas) - Masao Maeda (brtriver) + - Damien Harper (damien.harper) - Darius Leskauskas (darles) - david perez (davidpv) - Daniël Brekelmans (dbrekelmans) @@ -2059,6 +2105,7 @@ Symfony is the result of the work of many people who made the code better - Pierre Gasté (pierre_g) - Pablo Monterde Perez (plebs) - Jimmy Leger (redpanda) + - Dmitry (staratel) - Marcin Szepczynski (szepczynski) - Cyrille Jouineau (tuxosaurus) - Vladimir Chernyshev (volch) @@ -2069,7 +2116,6 @@ Symfony is the result of the work of many people who made the code better - Angel Fernando Quiroz Campos - Ondrej Mirtes - akimsko - - Stefan Kruppa - Youpie - srsbiz - Taylan Kasap @@ -2087,6 +2133,7 @@ Symfony is the result of the work of many people who made the code better - Damian Sromek - Ben - Evgeniy Tetenchuk + - Sjoerd Adema - Shrey Puranik - Lars Moelleken - dasmfm @@ -2137,6 +2184,7 @@ Symfony is the result of the work of many people who made the code better - BenjaminBeck - Aurelijus Rožėnas - Beno!t POLASZEK + - Armando - Jordan Hoff - znerol - Christian Eikermann @@ -2167,6 +2215,7 @@ Symfony is the result of the work of many people who made the code better - Jack Wright - MrNicodemuz - Anonymous User + - Dieter - Paweł Tomulik - Eric J. Duran - Alexandru Bucur @@ -2224,9 +2273,9 @@ Symfony is the result of the work of many people who made the code better - Shude - Richard Hodgson - Ondřej Führer + - Bogdan - Sema - Elan Ruusamäe - - Jon Dufresne - Thorsten Hallwas - Alex Nostadt - Michael Squires @@ -2278,6 +2327,7 @@ Symfony is the result of the work of many people who made the code better - tirnanog06 - phc - Дмитрий Пацура + - Signor Pedro - ilyes kooli - Ilia Lazarev - Michaël VEROUX @@ -2289,6 +2339,7 @@ Symfony is the result of the work of many people who made the code better - Bilge - ADmad - Nicolas Roudaire + - Matthias Meyer - Temuri Takalandze (abgeo) - Alfonso (afgar) - Andreas Forsblom (aforsblo) @@ -2319,7 +2370,6 @@ Symfony is the result of the work of many people who made the code better - Carsten Eilers (fnc) - Sorin Gitlan (forapathy) - Yohan Giarelli (frequence-web) - - Jesse Rushlow (geeshoe) - Gerry Vandermaesen (gerryvdm) - Ghazy Ben Ahmed (ghazy) - Arash Tabriziyan (ghost098) @@ -2386,10 +2436,10 @@ Symfony is the result of the work of many people who made the code better - Thomas Baumgartner (shoplifter) - Schuyler Jager (sjager) - Volker (skydiablo) + - Success Go (successgo) - Julien Sanchez (sumbobyboys) - Guillermo Gisinger (t3chn0r) - Markus Tacker (tacker) - - Thiago Cordeiro (thiagocordeiro) - Tom Newby (tomnewbyau) - Andrew Clark (tqt_andrew_clark) - David Lumaye (tux1124) @@ -2411,6 +2461,7 @@ Symfony is the result of the work of many people who made the code better - craigmarvelley - Stano Turza - simpson + - Antoine Leblanc - drublic - MaPePeR - Andreas Streichardt @@ -2440,7 +2491,6 @@ Symfony is the result of the work of many people who made the code better - max - Alexander Bauer (abauer) - Ahmad Mayahi (ahmadmayahi) - - Alireza Mirsepassi (alirezamirsepassi) - Mohamed Karnichi (amiral) - Andrew Carter (andrewcarteruk) - Adam Elsodaney (archfizz) From dfc775c59030bb8136e1fefe0da70a7c24489f93 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Sat, 29 Feb 2020 11:16:41 +0100 Subject: [PATCH 03/17] updated VERSION for 3.4.38 --- src/Symfony/Component/HttpKernel/Kernel.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php index 82930d8c27d2..1c85a2b08fd9 100644 --- a/src/Symfony/Component/HttpKernel/Kernel.php +++ b/src/Symfony/Component/HttpKernel/Kernel.php @@ -67,12 +67,12 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl private $requestStackSize = 0; private $resetServices = false; - const VERSION = '3.4.38-DEV'; + const VERSION = '3.4.38'; const VERSION_ID = 30438; const MAJOR_VERSION = 3; const MINOR_VERSION = 4; const RELEASE_VERSION = 38; - const EXTRA_VERSION = 'DEV'; + const EXTRA_VERSION = ''; const END_OF_MAINTENANCE = '11/2020'; const END_OF_LIFE = '11/2021'; From 8d2990e636d297161c4c02840adc0355594b1d11 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Sat, 29 Feb 2020 11:30:13 +0100 Subject: [PATCH 04/17] bumped Symfony version to 3.4.39 --- src/Symfony/Component/HttpKernel/Kernel.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php index 1c85a2b08fd9..4ef763e4862a 100644 --- a/src/Symfony/Component/HttpKernel/Kernel.php +++ b/src/Symfony/Component/HttpKernel/Kernel.php @@ -67,12 +67,12 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl private $requestStackSize = 0; private $resetServices = false; - const VERSION = '3.4.38'; - const VERSION_ID = 30438; + const VERSION = '3.4.39-DEV'; + const VERSION_ID = 30439; const MAJOR_VERSION = 3; const MINOR_VERSION = 4; - const RELEASE_VERSION = 38; - const EXTRA_VERSION = ''; + const RELEASE_VERSION = 39; + const EXTRA_VERSION = 'DEV'; const END_OF_MAINTENANCE = '11/2020'; const END_OF_LIFE = '11/2021'; From 1bd779d7c801d2fb56d16f479ca7d41c19185c44 Mon Sep 17 00:00:00 2001 From: Jules Pietri Date: Sat, 29 Feb 2020 22:44:21 +0100 Subject: [PATCH 05/17] [SecurityBundle] Minor fixes in configuration tree builder --- .../Security/Factory/RememberMeFactory.php | 4 +++- .../Security/UserProvider/LdapFactory.php | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php index 8d419c0edd8f..89953502ba76 100644 --- a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php +++ b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php @@ -139,12 +139,14 @@ public function addConfiguration(NodeDefinition $node) ->end() ->prototype('scalar')->end() ->end() - ->scalarNode('catch_exceptions')->defaultTrue()->end() + ->booleanNode('catch_exceptions')->defaultTrue()->end() ; foreach ($this->options as $name => $value) { if (\is_bool($value)) { $builder->booleanNode($name)->defaultValue($value); + } elseif (\is_int($value)) { + $builder->integerNode($name)->defaultValue($value); } else { $builder->scalarNode($name)->defaultValue($value); } diff --git a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/UserProvider/LdapFactory.php b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/UserProvider/LdapFactory.php index f213a32f8b7d..35681623ed29 100644 --- a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/UserProvider/LdapFactory.php +++ b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/UserProvider/LdapFactory.php @@ -47,11 +47,12 @@ public function getKey() public function addConfiguration(NodeDefinition $node) { $node + ->fixXmlConfig('default_role') ->children() ->scalarNode('service')->isRequired()->cannotBeEmpty()->defaultValue('ldap')->end() ->scalarNode('base_dn')->isRequired()->cannotBeEmpty()->end() - ->scalarNode('search_dn')->end() - ->scalarNode('search_password')->end() + ->scalarNode('search_dn')->defaultNull()->end() + ->scalarNode('search_password')->defaultNull()->end() ->arrayNode('default_roles') ->beforeNormalization()->ifString()->then(function ($v) { return preg_split('/\s*,\s*/', $v); })->end() ->requiresAtLeastOneElement() From 8c498ee48737ceb5ce9612abc277b1480d85997c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Przemys=C5=82aw=20Bogusz?= Date: Sun, 1 Mar 2020 22:11:17 +0100 Subject: [PATCH 06/17] Add Polish translation --- .../Validator/Resources/translations/validators.pl.xlf | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.pl.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.pl.xlf index d1dd1471a77c..5c1e472ab5b6 100644 --- a/src/Symfony/Component/Validator/Resources/translations/validators.pl.xlf +++ b/src/Symfony/Component/Validator/Resources/translations/validators.pl.xlf @@ -370,6 +370,10 @@ This value is not a valid hostname. Ta wartość nie jest prawidłową nazwą hosta. + + The number of elements in this collection should be a multiple of {{ compared_value }}. + Liczba elementów w tym zbiorze powinna być wielokrotnością {{ compared_value }}. + From 44ba43d6730b81859989a2267c733b3b7bc32b27 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Mon, 2 Mar 2020 09:42:21 +0100 Subject: [PATCH 07/17] Fix typo --- .../Validator/Resources/translations/validators.vi.xlf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.vi.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.vi.xlf index ead79d2cd7e5..301d42f027c8 100644 --- a/src/Symfony/Component/Validator/Resources/translations/validators.vi.xlf +++ b/src/Symfony/Component/Validator/Resources/translations/validators.vi.xlf @@ -372,7 +372,7 @@ The number of elements in this collection should be a multiple of {{ compared_value }}. - Số lượng các phần tử trong bộ sưu tập này nên là bội số của {{compared_value}}. + Số lượng các phần tử trong bộ sưu tập này nên là bội số của {{ compared_value }}. From af738c0c8f752b8d00020cfdbbcda13da2717103 Mon Sep 17 00:00:00 2001 From: arai Date: Sat, 29 Feb 2020 09:37:39 +0900 Subject: [PATCH 08/17] [Validator] add Japanese translation --- .../Validator/Resources/translations/validators.ja.xlf | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf index 21e2392c7d96..f4e4f699467d 100644 --- a/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf +++ b/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf @@ -366,6 +366,14 @@ This value should be between {{ min }} and {{ max }}. {{ min }}以上{{ max }}以下でなければなりません。 + + This value is not a valid hostname. + 有効なホスト名ではありません。 + + + The number of elements in this collection should be a multiple of {{ compared_value }}. + 要素の数は{{Compare_value}}の倍数でなければなりません。 + From 6cb49b5e0cb430e4a7df3962e2fdc9bbe30cca5d Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Mon, 2 Mar 2020 09:43:43 +0100 Subject: [PATCH 09/17] Fix typo --- .../Validator/Resources/translations/validators.ja.xlf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf index f4e4f699467d..8bff68b1ee90 100644 --- a/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf +++ b/src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf @@ -372,7 +372,7 @@ The number of elements in this collection should be a multiple of {{ compared_value }}. - 要素の数は{{Compare_value}}の倍数でなければなりません。 + 要素の数は{{ compared_value }}の倍数でなければなりません。 From 9e67b57baa597303368a01bf485aefdaae51cd27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Przemys=C5=82aw=20Bogusz?= Date: Sun, 1 Mar 2020 22:30:42 +0100 Subject: [PATCH 10/17] Add Spanish translation --- .../Validator/Resources/translations/validators.es.xlf | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.es.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.es.xlf index 75cb60605a6b..08ec74c05b8f 100644 --- a/src/Symfony/Component/Validator/Resources/translations/validators.es.xlf +++ b/src/Symfony/Component/Validator/Resources/translations/validators.es.xlf @@ -364,7 +364,15 @@ This value should be between {{ min }} and {{ max }}. - Este valor debe estar entre {{ min }} y {{ max }}. + Este valor debería estar entre {{ min }} y {{ max }}. + + + This value is not a valid hostname. + Este valor no es un nombre de host válido. + + + The number of elements in this collection should be a multiple of {{ compared_value }}. + El número de elementos en esta colección debería ser múltiplo de {{ compared_value }}. From af17f5a9ace0ab2013d50f33af9d37f200477d96 Mon Sep 17 00:00:00 2001 From: David Maicher Date: Tue, 3 Mar 2020 14:44:39 +0100 Subject: [PATCH 11/17] Revert "bug symfony#28179 [DomCrawler] Skip disabled fields processing in Form" This reverts commit c73b042044ef26e0d9b7eec2c6ea9db0a74759ef. --- src/Symfony/Component/DomCrawler/Form.php | 10 +++++++++- .../Component/DomCrawler/Tests/FormTest.php | 16 ++++++++-------- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/src/Symfony/Component/DomCrawler/Form.php b/src/Symfony/Component/DomCrawler/Form.php index 0a86c7e6d406..8a6e28ca86c3 100644 --- a/src/Symfony/Component/DomCrawler/Form.php +++ b/src/Symfony/Component/DomCrawler/Form.php @@ -89,6 +89,10 @@ public function getValues() { $values = []; foreach ($this->fields->all() as $name => $field) { + if ($field->isDisabled()) { + continue; + } + if (!$field instanceof Field\FileFormField && $field->hasValue()) { $values[$name] = $field->getValue(); } @@ -111,6 +115,10 @@ public function getFiles() $files = []; foreach ($this->fields->all() as $name => $field) { + if ($field->isDisabled()) { + continue; + } + if ($field instanceof Field\FileFormField) { $files[$name] = $field->getValue(); } @@ -455,7 +463,7 @@ private function initialize() private function addField(\DOMElement $node) { - if (!$node->hasAttribute('name') || !$node->getAttribute('name') || $node->hasAttribute('disabled')) { + if (!$node->hasAttribute('name') || !$node->getAttribute('name')) { return; } diff --git a/src/Symfony/Component/DomCrawler/Tests/FormTest.php b/src/Symfony/Component/DomCrawler/Tests/FormTest.php index 9894eb429a9e..f042513f8d68 100644 --- a/src/Symfony/Component/DomCrawler/Tests/FormTest.php +++ b/src/Symfony/Component/DomCrawler/Tests/FormTest.php @@ -159,12 +159,12 @@ public function testConstructorHandlesFormValues() public function testMultiValuedFields() { $form = $this->createForm('
- - - - - - + + + + + +
'); @@ -227,10 +227,10 @@ public function provideInitializeValues() [], ], [ - 'skips disabled input fields', + 'takes into account disabled input fields', ' ', - [], + ['foo' => ['InputFormField', 'foo']], ], [ 'appends the submitted button value', From 0caf94792479c43111339f6f1062a9de88e573d1 Mon Sep 17 00:00:00 2001 From: Thomas Calvet Date: Thu, 5 Mar 2020 10:39:55 +0100 Subject: [PATCH 12/17] Use some PHP 5.4 constants unconditionally --- .../Bundle/FrameworkBundle/Templating/Helper/FormHelper.php | 4 ++-- src/Symfony/Component/Form/FormRenderer.php | 4 ++-- src/Symfony/Component/Translation/Dumper/JsonFileDumper.php | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Symfony/Bundle/FrameworkBundle/Templating/Helper/FormHelper.php b/src/Symfony/Bundle/FrameworkBundle/Templating/Helper/FormHelper.php index 686777f74557..d9a008c690ac 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Templating/Helper/FormHelper.php +++ b/src/Symfony/Bundle/FrameworkBundle/Templating/Helper/FormHelper.php @@ -243,9 +243,9 @@ public function humanize($text) public function formEncodeCurrency($text, $widget = '') { if ('UTF-8' === $charset = $this->getCharset()) { - $text = htmlspecialchars($text, ENT_QUOTES | (\defined('ENT_SUBSTITUTE') ? ENT_SUBSTITUTE : 0), 'UTF-8'); + $text = htmlspecialchars($text, ENT_QUOTES | ENT_SUBSTITUTE, 'UTF-8'); } else { - $text = htmlentities($text, ENT_QUOTES | (\defined('ENT_SUBSTITUTE') ? ENT_SUBSTITUTE : 0), 'UTF-8'); + $text = htmlentities($text, ENT_QUOTES | ENT_SUBSTITUTE, 'UTF-8'); $text = iconv('UTF-8', $charset, $text); $widget = iconv('UTF-8', $charset, $widget); } diff --git a/src/Symfony/Component/Form/FormRenderer.php b/src/Symfony/Component/Form/FormRenderer.php index 8b15e0344d0c..61adc203765e 100644 --- a/src/Symfony/Component/Form/FormRenderer.php +++ b/src/Symfony/Component/Form/FormRenderer.php @@ -291,9 +291,9 @@ public function humanize($text) public function encodeCurrency(Environment $environment, $text, $widget = '') { if ('UTF-8' === $charset = $environment->getCharset()) { - $text = htmlspecialchars($text, ENT_QUOTES | (\defined('ENT_SUBSTITUTE') ? ENT_SUBSTITUTE : 0), 'UTF-8'); + $text = htmlspecialchars($text, ENT_QUOTES | ENT_SUBSTITUTE, 'UTF-8'); } else { - $text = htmlentities($text, ENT_QUOTES | (\defined('ENT_SUBSTITUTE') ? ENT_SUBSTITUTE : 0), 'UTF-8'); + $text = htmlentities($text, ENT_QUOTES | ENT_SUBSTITUTE, 'UTF-8'); $text = iconv('UTF-8', $charset, $text); $widget = iconv('UTF-8', $charset, $widget); } diff --git a/src/Symfony/Component/Translation/Dumper/JsonFileDumper.php b/src/Symfony/Component/Translation/Dumper/JsonFileDumper.php index 3ee446dc7318..15e065acecbd 100644 --- a/src/Symfony/Component/Translation/Dumper/JsonFileDumper.php +++ b/src/Symfony/Component/Translation/Dumper/JsonFileDumper.php @@ -28,7 +28,7 @@ public function formatCatalogue(MessageCatalogue $messages, $domain, array $opti if (isset($options['json_encoding'])) { $flags = $options['json_encoding']; } else { - $flags = \defined('JSON_PRETTY_PRINT') ? JSON_PRETTY_PRINT : 0; + $flags = JSON_PRETTY_PRINT; } return json_encode($messages->all($domain), $flags); From 9cc8d39c3966cb96ab2f62e5957d7b9accd131d0 Mon Sep 17 00:00:00 2001 From: Reda DAOUDI Date: Thu, 5 Mar 2020 11:31:37 +0100 Subject: [PATCH 13/17] [Validator] Add two missing translations for the Arabic (ar) locale --- .../Validator/Resources/translations/validators.ar.xlf | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.ar.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.ar.xlf index 79dab63d7de5..7c509b482250 100644 --- a/src/Symfony/Component/Validator/Resources/translations/validators.ar.xlf +++ b/src/Symfony/Component/Validator/Resources/translations/validators.ar.xlf @@ -366,6 +366,14 @@ This value should be between {{ min }} and {{ max }}. يجب أن تكون هذه القيمة بين {{ min }} و {{ max }}. + + This value is not a valid hostname. + هذه القيمة ليست اسم مضيف صالح. + + + The number of elements in this collection should be a multiple of {{ compared_value }}. + يجب أن يكون عدد العناصر في هذه المجموعة مضاعف {{ compared_value }}. + From a56d2626392a163fb12f6772d076a07ba463bef4 Mon Sep 17 00:00:00 2001 From: Jesse Rushlow Date: Tue, 3 Mar 2020 08:15:33 -0500 Subject: [PATCH 14/17] improve PlaintextPasswordEncoder docBlock summary --- .../Security/Core/Encoder/PlaintextPasswordEncoder.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Symfony/Component/Security/Core/Encoder/PlaintextPasswordEncoder.php b/src/Symfony/Component/Security/Core/Encoder/PlaintextPasswordEncoder.php index bda6269a5201..9e6c7570d8ab 100644 --- a/src/Symfony/Component/Security/Core/Encoder/PlaintextPasswordEncoder.php +++ b/src/Symfony/Component/Security/Core/Encoder/PlaintextPasswordEncoder.php @@ -14,7 +14,9 @@ use Symfony\Component\Security\Core\Exception\BadCredentialsException; /** - * PlaintextPasswordEncoder does not do any encoding. + * PlaintextPasswordEncoder does not do any encoding but is useful in testing environments. + * + * As this encoder is not cryptographically secure, usage of it in production environments is not recommended. * * @author Fabien Potencier */ From 622facfe94e347e31b46e2d86297a1c1ca74cbc3 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Thu, 5 Mar 2020 12:34:29 +0100 Subject: [PATCH 15/17] Tweak message --- .../Security/Core/Encoder/PlaintextPasswordEncoder.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/Security/Core/Encoder/PlaintextPasswordEncoder.php b/src/Symfony/Component/Security/Core/Encoder/PlaintextPasswordEncoder.php index 9e6c7570d8ab..e2c127aa538f 100644 --- a/src/Symfony/Component/Security/Core/Encoder/PlaintextPasswordEncoder.php +++ b/src/Symfony/Component/Security/Core/Encoder/PlaintextPasswordEncoder.php @@ -16,7 +16,7 @@ /** * PlaintextPasswordEncoder does not do any encoding but is useful in testing environments. * - * As this encoder is not cryptographically secure, usage of it in production environments is not recommended. + * As this encoder is not cryptographically secure, usage of it in production environments is discouraged. * * @author Fabien Potencier */ From be7afc6d85cae3d745a7fbc2af0c14b7870c80f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Przemys=C5=82aw=20Bogusz?= Date: Thu, 5 Mar 2020 17:34:39 +0100 Subject: [PATCH 16/17] [DI] Fix XmlFileLoader bad error message --- .../Tests/Fixtures/Util/not_readable.xml | 0 .../Config/Tests/Util/XmlUtilsTest.php | 29 +++++++++++++++++-- .../Component/Config/Util/XmlUtils.php | 11 ++++++- 3 files changed, 37 insertions(+), 3 deletions(-) create mode 100644 src/Symfony/Component/Config/Tests/Fixtures/Util/not_readable.xml diff --git a/src/Symfony/Component/Config/Tests/Fixtures/Util/not_readable.xml b/src/Symfony/Component/Config/Tests/Fixtures/Util/not_readable.xml new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/src/Symfony/Component/Config/Tests/Util/XmlUtilsTest.php b/src/Symfony/Component/Config/Tests/Util/XmlUtilsTest.php index d1a47a8ea337..0378e7b69a97 100644 --- a/src/Symfony/Component/Config/Tests/Util/XmlUtilsTest.php +++ b/src/Symfony/Component/Config/Tests/Util/XmlUtilsTest.php @@ -20,6 +20,31 @@ public function testLoadFile() { $fixtures = __DIR__.'/../Fixtures/Util/'; + try { + XmlUtils::loadFile($fixtures); + $this->fail(); + } catch (\InvalidArgumentException $e) { + $this->assertStringContainsString('is not a file', $e->getMessage()); + } + + try { + XmlUtils::loadFile($fixtures.'non_existing.xml'); + $this->fail(); + } catch (\InvalidArgumentException $e) { + $this->assertStringContainsString('is not a file', $e->getMessage()); + } + + try { + if ('\\' === \DIRECTORY_SEPARATOR) { + $this->markTestSkipped('chmod is not supported on Windows'); + } + chmod($fixtures.'not_readable.xml', 000); + XmlUtils::loadFile($fixtures.'not_readable.xml'); + $this->fail(); + } catch (\InvalidArgumentException $e) { + $this->assertStringContainsString('is not readable', $e->getMessage()); + } + try { XmlUtils::loadFile($fixtures.'invalid.xml'); $this->fail(); @@ -165,7 +190,7 @@ public function testLoadEmptyXmlFile() $file = __DIR__.'/../Fixtures/foo.xml'; $this->expectException('InvalidArgumentException'); - $this->expectExceptionMessage(sprintf('File %s does not contain valid XML, it is empty.', $file)); + $this->expectExceptionMessage(sprintf('File "%s" does not contain valid XML, it is empty.', $file)); XmlUtils::loadFile($file); } @@ -186,7 +211,7 @@ public function testLoadWrongEmptyXMLWithErrorHandler() XmlUtils::loadFile($file); $this->fail('An exception should have been raised'); } catch (\InvalidArgumentException $e) { - $this->assertEquals(sprintf('File %s does not contain valid XML, it is empty.', $file), $e->getMessage()); + $this->assertEquals(sprintf('File "%s" does not contain valid XML, it is empty.', $file), $e->getMessage()); } } finally { restore_error_handler(); diff --git a/src/Symfony/Component/Config/Util/XmlUtils.php b/src/Symfony/Component/Config/Util/XmlUtils.php index d0042af30226..c925f315e5ed 100644 --- a/src/Symfony/Component/Config/Util/XmlUtils.php +++ b/src/Symfony/Component/Config/Util/XmlUtils.php @@ -122,9 +122,18 @@ public static function parse($content, $schemaOrCallable = null) */ public static function loadFile($file, $schemaOrCallable = null) { + if (!is_file($file)) { + throw new \InvalidArgumentException(sprintf('Resource "%s" is not a file.', $file)); + } + + if (!is_readable($file)) { + throw new \InvalidArgumentException(sprintf('File "%s" is not readable.', $file)); + } + $content = @file_get_contents($file); + if ('' === trim($content)) { - throw new \InvalidArgumentException(sprintf('File %s does not contain valid XML, it is empty.', $file)); + throw new \InvalidArgumentException(sprintf('File "%s" does not contain valid XML, it is empty.', $file)); } try { From da7870433f0567cde7371d66192103d417e99661 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Sat, 7 Mar 2020 12:56:51 +0100 Subject: [PATCH 17/17] [Yaml] fix dumping strings containing CRs --- src/Symfony/Component/Yaml/Dumper.php | 2 +- src/Symfony/Component/Yaml/Tests/DumperTest.php | 17 ++++++++++++++++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Yaml/Dumper.php b/src/Symfony/Component/Yaml/Dumper.php index a496dcc88ec2..5daf22e3119f 100644 --- a/src/Symfony/Component/Yaml/Dumper.php +++ b/src/Symfony/Component/Yaml/Dumper.php @@ -99,7 +99,7 @@ public function dump($input, $inline = 0, $indent = 0, $flags = 0) $dumpAsMap = Inline::isHash($input); foreach ($input as $key => $value) { - if ($inline >= 1 && Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK & $flags && \is_string($value) && false !== strpos($value, "\n") && false === strpos($value, "\r\n")) { + if ($inline >= 1 && Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK & $flags && \is_string($value) && false !== strpos($value, "\n") && false === strpos($value, "\r")) { // If the first line starts with a space character, the spec requires a blockIndicationIndicator // http://www.yaml.org/spec/1.2/spec.html#id2793979 $blockIndentationIndicator = (' ' === substr($value, 0, 1)) ? (string) $this->indentation : ''; diff --git a/src/Symfony/Component/Yaml/Tests/DumperTest.php b/src/Symfony/Component/Yaml/Tests/DumperTest.php index 1a1ef25a5a4b..074c94942acf 100644 --- a/src/Symfony/Component/Yaml/Tests/DumperTest.php +++ b/src/Symfony/Component/Yaml/Tests/DumperTest.php @@ -580,11 +580,26 @@ public function testDumpMultiLineStringAsScalarBlockWhenFirstLineHasLeadingSpace $this->assertSame(file_get_contents(__DIR__.'/Fixtures/multiple_lines_as_literal_block_leading_space_in_first_line.yml'), $this->dumper->dump($data, 2, 0, Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK)); } - public function testCarriageReturnIsMaintainedWhenDumpingAsMultiLineLiteralBlock() + public function testCarriageReturnFollowedByNewlineIsMaintainedWhenDumpingAsMultiLineLiteralBlock() { $this->assertSame("- \"a\\r\\nb\\nc\"\n", $this->dumper->dump(["a\r\nb\nc"], 2, 0, Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK)); } + public function testCarriageReturnNotFollowedByNewlineIsPreservedWhenDumpingAsMultiLineLiteralBlock() + { + $expected = <<<'YAML' +parent: + foo: "bar\n\rbaz: qux" + +YAML; + + $this->assertSame($expected, $this->dumper->dump([ + 'parent' => [ + 'foo' => "bar\n\rbaz: qux", + ], + ], 4, 0, Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK)); + } + public function testZeroIndentationThrowsException() { $this->expectException('InvalidArgumentException');