[PhpUnitBridge] Fix some errors when using serialized deprecations

[greg0ire]

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	n/a
License	MIT
Doc PR	n/a

This PR attempts to fix conflicts that arose in #31478

Creating as a draft for now as I think having separate test methods no longer make sense (isSelf() and isIndirect() have been replaced with getType()). @l-vo please review and confirm I did not loose anything valuable from your original contribution.

[greg0ire]

I just renamed test methods that were tied to methods that no longer exists (isSelf(), isIndirect()). I think we'll have to do without a review from @l-vo …

[l-vo]

@greg0ire Excuse me, I'm currently running out of time and I have to get back into the context. But I'm going to look at this as soon as I can 😊

[l-vo]

I reviewed and tested the changes, it looks good to me. Although there is a problem, the tests don't pass. The changes on the type "self" determination makes the type "self" difficult to test.

[l-vo]

Don't pass anymore. A way to test it:

foreach (get_declared_classes() as $class) {
            if ('C' === $class[0] && 0 === strpos($class, 'ComposerAutoloaderInit')) {
                $r = new \ReflectionClass($class);
                $v = \dirname(\dirname($r->getFileName()));
                if (file_exists($v.'/composer/installed.json')) {
                    $loader = require $v.'/autoload.php';
                    $reflection = new \ReflectionClass($loader);
                    $prop = $reflection->getProperty('prefixDirsPsr4');
                    $prop->setAccessible(true);
                    $currentValue = $prop->getValue($loader);
                    $currentValue['Symfony\\Bridge\\PhpUnit\\'] = [realpath(__DIR__.'/../..')];
                    $prop->setValue($loader, $currentValue);
                }
            }
        }

return [
            'not_from_vendors_file' => [Deprecation::TYPE_SELF, '', 'MyClass1', __FILE__],
            //...
];

[greg0ire]

Cannot say I understand but I applied this change 😅

[l-vo]

It's just change composer loader psr4 paths which are used to determine "self" type :)

[l-vo]

Hum it will depend from where tests are launched. I think we can remove this data provided.

[greg0ire]

removed

[l-vo]

it will depend from where tests are launched. I think we can remove this data provided.

[greg0ire]

removed

[greg0ire]

@l-vo I applied your suggestions, please review again :)
Note that the patch from fabbot should not be applied as code in this particular component should still be compatible with php 5.5.9

[l-vo]

LGTM :)

[nicolas-grekas]

Thank you @greg0ire.